Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2142733002: Modified iterable keyframes test to use KeyframeEffect constructor and (Closed)

Created:
4 years, 5 months ago by shans
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modified iterable keyframes test to use KeyframeEffect constructor and getFrames directly. Note that this test will not pass in Chrome and is intended for upload to web-platform-tests. Added original test to animations directory to maintain coverage. BUG=623437 Committed: https://crrev.com/94356d17d5aec284672b75ad0ccbbba09d154567 Cr-Commit-Position: refs/heads/master@{#404861}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add test expectations now that this test fails #

Messages

Total messages: 21 (7 generated)
shans
4 years, 5 months ago (2016-07-12 01:54:01 UTC) #2
alancutter (OOO until 2018)
lgtm with nit. https://codereview.chromium.org/2142733002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/keyframe-effect-iterable-keyframes.html File third_party/WebKit/LayoutTests/web-animations-api/keyframe-effect-iterable-keyframes.html (right): https://codereview.chromium.org/2142733002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/keyframe-effect-iterable-keyframes.html#newcode77 third_party/WebKit/LayoutTests/web-animations-api/keyframe-effect-iterable-keyframes.html:77: {at: 0.5, is: {left: '300px'}}, Why ...
4 years, 5 months ago (2016-07-12 03:44:54 UTC) #3
shans
On 2016/07/12 at 03:44:54, alancutter wrote: > lgtm with nit. > > https://codereview.chromium.org/2142733002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/keyframe-effect-iterable-keyframes.html > File ...
4 years, 5 months ago (2016-07-12 03:54:58 UTC) #4
shans
4 years, 5 months ago (2016-07-12 03:55:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142733002/1
4 years, 5 months ago (2016-07-12 04:14:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/258227)
4 years, 5 months ago (2016-07-12 05:25:27 UTC) #9
shans
On 2016/07/12 at 05:25:27, commit-bot wrote: > Try jobs failed on following builders: > mac_chromium_rel_ng ...
4 years, 5 months ago (2016-07-12 06:13:05 UTC) #10
alancutter (OOO until 2018)
lgtm
4 years, 5 months ago (2016-07-12 06:13:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142733002/20001
4 years, 5 months ago (2016-07-12 06:14:23 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/253839)
4 years, 5 months ago (2016-07-12 06:40:08 UTC) #15
alancutter (OOO until 2018)
On 2016/07/12 at 06:40:08, commit-bot wrote: > Try jobs failed on following builders: > win_chromium_rel_ng ...
4 years, 5 months ago (2016-07-12 07:53:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142733002/20001
4 years, 5 months ago (2016-07-12 22:17:38 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-12 23:44:47 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 23:47:03 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/94356d17d5aec284672b75ad0ccbbba09d154567
Cr-Commit-Position: refs/heads/master@{#404861}

Powered by Google App Engine
This is Rietveld 408576698