Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2142703002: [Offline Pages] Showing expired pages in internal page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.cc
diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc
index 8642ab137cadd30b0c337de6a28463c82e85c2d6..5159fefd32b286f64da49d5e436bc48b6d24399d 100644
--- a/components/offline_pages/offline_page_model_impl.cc
+++ b/components/offline_pages/offline_page_model_impl.cc
@@ -450,16 +450,26 @@ void OfflinePageModelImpl::CheckPagesExistOfflineAfterLoadDone(
void OfflinePageModelImpl::GetAllPages(
const MultipleOfflinePageItemCallback& callback) {
RunWhenLoaded(base::Bind(&OfflinePageModelImpl::GetAllPagesAfterLoadDone,
- weak_ptr_factory_.GetWeakPtr(), callback));
+ weak_ptr_factory_.GetWeakPtr(), GetAllPageMode::ALL,
+ callback));
+}
+
+void OfflinePageModelImpl::GetAllPagesWithExpired(
+ const MultipleOfflinePageItemCallback& callback) {
+ RunWhenLoaded(base::Bind(&OfflinePageModelImpl::GetAllPagesAfterLoadDone,
+ weak_ptr_factory_.GetWeakPtr(),
+ GetAllPageMode::ALL_WITH_EXPIRED, callback));
}
void OfflinePageModelImpl::GetAllPagesAfterLoadDone(
+ GetAllPageMode mode,
const MultipleOfflinePageItemCallback& callback) const {
DCHECK(is_loaded_);
MultipleOfflinePageItemResult offline_pages;
for (const auto& id_page_pair : offline_pages_) {
- if (!id_page_pair.second.IsExpired())
+ if (mode == GetAllPageMode::ALL_WITH_EXPIRED ||
+ !id_page_pair.second.IsExpired())
offline_pages.push_back(id_page_pair.second);
}
« no previous file with comments | « components/offline_pages/offline_page_model_impl.h ('k') | components/offline_pages/stub_offline_page_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698