chrome/browser/ui/webui/offline_internals_ui.cc - Issue 2142703002: [Offline Pages] Showing expired pages in internal page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/offline_internals_ui.cc

Issue 2142703002: [Offline Pages] Showing expired pages in internal page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js ('k') | components/offline_pages/offline_page_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/offline_internals_ui.cc

diff --git a/chrome/browser/ui/webui/offline_internals_ui.cc b/chrome/browser/ui/webui/offline_internals_ui.cc

index 8968b824d3ca9333d3d22cd2e38837386cc4cb42..93ed44994e32922e0c036e5ce4402044ad82cd50 100644

--- a/chrome/browser/ui/webui/offline_internals_ui.cc

+++ b/chrome/browser/ui/webui/offline_internals_ui.cc

@@ -202,6 +202,7 @@ void OfflineInternalsUIMessageHandler::HandleStoredPagesCallback(

offline_page->SetDouble("lastAccessTime",

page.last_access_time.ToJsTime());

offline_page->SetInteger("accessCount", page.access_count);

+ offline_page->SetString("isExpired", page.IsExpired() ? "Yes" : "No");

}

ResolveJavascriptCallback(base::StringValue(callback_id), results);

}