[Offline Pages] Showing expired pages in internal page.

chrome/browser/resources/offline_pages/offline_internals.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('offlineInternals', function() {
   'use strict';
 
   /** @type {!Array<OfflinePage>} */
   var offlinePages = [];
 
@@ skipping 30 matching lines @@
       row.appendChild(cell);
 
       cell = document.createElement('td');
       cell.textContent = pages[i].namespace;
       row.appendChild(cell);
 
       cell = document.createElement('td');
       cell.textContent = Math.round(pages[i].size / 1024);
       row.appendChild(cell);
 
+      cell = document.createElement('td');
+      cell.textContent = pages[i].expired;

[michaelpg, 2016/07/13 00:09:21]

This will implicitly set textContent to 'true' or 'false' if I understand this
CL correctly. Please use an explicit string:
    pages[i].expired.toString()
or 'Yes'/'No' or whatever.

(Is that really what you want? Or would something like a "Status" column with a
possible "Expired" value make more sense?)

[romax, 2016/07/13 20:01:08]

I'll change it to Yes/No and I think it's enough. A 'status' column would have
some empty cells for the not-expired pages.

+      row.appendChild(cell);
+
       storedPagesTable.appendChild(row);
     }
     offlinePages = pages;
   }
 
   /**
    * Fill requests table.
    * @param {!Array<SavePageRequest>} requests An array object representing
    *     the request queue.
    */
@@ skipping 124 matching lines @@
     refreshAll();
   }
 
   // Return an object with all of the exports.
   return {
     initialize: initialize,
   };
 });
 
 document.addEventListener('DOMContentLoaded', offlineInternals.initialize);