Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2142653003: DevTools: move functionality away from ElementsPanel for better DOM tree control reuse. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move functionality away from ElementsPanel for better DOM tree control reuse. BUG=627306 Committed: https://crrev.com/876a4bf3c87650e733c34a494f7f1d9ef57a391d Cr-Commit-Position: refs/heads/master@{#405030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -78 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 11 chunks +32 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js View 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 2 chunks +39 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/module.json View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
pfeldman
4 years, 5 months ago (2016-07-12 01:06:40 UTC) #2
lushnikov
lgtm
4 years, 5 months ago (2016-07-12 02:13:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142653003/1
4 years, 5 months ago (2016-07-12 02:25:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/258169)
4 years, 5 months ago (2016-07-12 03:37:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142653003/1
4 years, 5 months ago (2016-07-12 21:27:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142653003/1
4 years, 5 months ago (2016-07-12 22:44:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142653003/1
4 years, 5 months ago (2016-07-12 23:51:03 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 04:55:49 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 04:56:00 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 04:57:21 UTC) #19
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/876a4bf3c87650e733c34a494f7f1d9ef57a391d
Cr-Commit-Position: refs/heads/master@{#405030}

Powered by Google App Engine
This is Rietveld 408576698