Disable Full-WPO for the x64 official build (non-PGO).

Disable Full-WPO for the x64 official build (non-PGO).

Disable Full-WPO for the x64 official builds (this doesn't
affect the PGO builds).

This should help me to get an official
"non-PGO & non-WPO" build that I can compare against an official PGO
build.

Also I'm not sure if it's worth keeping WPO turned on for the official
builds at the moment ? We don't ship these builds (we ship the PGO ones)
and so this only slowdown the builders that build an official x64 build
for testing purposes (especially considering that they need to link all the unittests with Full-WPO)

BUG=490934, 617982
Committed: https://crrev.com/0d74d7f71c93bfc3b32653de7958ff84d173937d
Cr-Commit-Position: refs/heads/master@{#405164}

[Sébastien Marchand, 2016-07-11 20:15:13]

sebmarchand@chromium.org changed reviewers:
+ brucedawson@chromium.org

[Sébastien Marchand, 2016-07-11 20:15:14]

PTAL.

[brucedawson, 2016-07-11 20:26:46]

On 2016/07/11 20:15:14, Sébastien Marchand wrote:
> PTAL.

I'm unclear on what the purpose is. Official builds of Chrome have always
implied WPO. For non-WPO builds you can just not set buildtype=Official.

If we turn off WPO on the official x64 builds then they will not be fully
optimized and will presumably run noticeably slower, which will make them less
valid for any sort of performance testing purposes.

If we want faster builds that generate slower code then why don't we just remove
buildtype=Official?

[Sébastien Marchand, 2016-07-11 20:36:38]

On 2016/07/11 20:26:46, brucedawson wrote:
> On 2016/07/11 20:15:14, Sébastien Marchand wrote:
> > PTAL.
> 
> I'm unclear on what the purpose is. Official builds of Chrome have always
> implied WPO. For non-WPO builds you can just not set buildtype=Official.
> 
> If we turn off WPO on the official x64 builds then they will not be fully
> optimized and will presumably run noticeably slower, which will make them less
> valid for any sort of performance testing purposes.
> 
> If we want faster builds that generate slower code then why don't we just
remove
> buildtype=Official?

Because buildtype=Official imply several other things (some conditional code
etc), here I'm just disabling FULL WPO, the partial WPO is still enabled. Full
WPO has a huge impact on the official builders that build unittests (because the
large tests take a lot of time to link with full WPO), so I'm not sure that we
want to keep building a configuration that we don't ship ?

Note that I'm doing this in order to get some non-wpo official x64 builds, I
could be convinced that keeping WPO for the official builds is the right thing
to do :)

[brucedawson, 2016-07-11 20:41:45]

> Because buildtype=Official imply several other things (some conditional code
> etc), here I'm just disabling FULL WPO, the partial WPO is still enabled. Full
> WPO has a huge impact on the official builders that build unittests (because
the
> large tests take a lot of time to link with full WPO), so I'm not sure that we
> want to keep building a configuration that we don't ship ?

Well, either way we're building a configuration that we don't ship.

> Note that I'm doing this in order to get some non-wpo official x64 builds, I
> could be convinced that keeping WPO for the official builds is the right thing
> to do :)

The title and description should be updated to make it clear that you are
disabling full-WPO, since that is quite different from disabling WPO (which
implies fully disabling it). Avoiding excessive build times for the unit tests
does make sense, since we don't really benefit from the run-time improvements
there.

[Sébastien Marchand, 2016-07-11 20:59:21]

Description was changed from

==========
Disable WPO for the x64 official build (non-PGO).

(temporarily ?) disable WPO for the x64 official builds (this doesn't
affect the PGO builds). This should help me to get an official
"non-PGO & non-WPO" build that I can compare against an official PGO
build.

Also I'm not sure if it's worth keeping WPO turned on for the official
builds at the moment ? We don't ship these builds (we ship the PGO ones)
and so this only slowdown the builders that build an official x64 build
for testing purposes.

BUG=490934
==========

to

==========
Disable Full-WPO for the x64 official build (non-PGO).

Disable Full-WPO for the x64 official builds (this doesn't
affect the PGO builds).


This should help me to get an official
"non-PGO & non-WPO" build that I can compare against an official PGO
build.

Also I'm not sure if it's worth keeping WPO turned on for the official
builds at the moment ? We don't ship these builds (we ship the PGO ones)
and so this only slowdown the builders that build an official x64 build
for testing purposes (especially considering that they need to link all the
unittests with Full-WPO

BUG=490934
==========

[Sébastien Marchand, 2016-07-11 21:03:42]

Description was changed from

==========
Disable Full-WPO for the x64 official build (non-PGO).

Disable Full-WPO for the x64 official builds (this doesn't
affect the PGO builds).


This should help me to get an official
"non-PGO & non-WPO" build that I can compare against an official PGO
build.

Also I'm not sure if it's worth keeping WPO turned on for the official
builds at the moment ? We don't ship these builds (we ship the PGO ones)
and so this only slowdown the builders that build an official x64 build
for testing purposes (especially considering that they need to link all the
unittests with Full-WPO

BUG=490934
==========

to

==========
Disable Full-WPO for the x64 official build (non-PGO).

Disable Full-WPO for the x64 official builds (this doesn't
affect the PGO builds).


This should help me to get an official
"non-PGO & non-WPO" build that I can compare against an official PGO
build.

Also I'm not sure if it's worth keeping WPO turned on for the official
builds at the moment ? We don't ship these builds (we ship the PGO ones)
and so this only slowdown the builders that build an official x64 build
for testing purposes (especially considering that they need to link all the
unittests with Full-WPO

BUG=490934, 617982
==========

[Sébastien Marchand, 2016-07-11 21:03:58]

Description was changed from

==========
Disable Full-WPO for the x64 official build (non-PGO).

Disable Full-WPO for the x64 official builds (this doesn't
affect the PGO builds).


This should help me to get an official
"non-PGO & non-WPO" build that I can compare against an official PGO
build.

Also I'm not sure if it's worth keeping WPO turned on for the official
builds at the moment ? We don't ship these builds (we ship the PGO ones)
and so this only slowdown the builders that build an official x64 build
for testing purposes (especially considering that they need to link all the
unittests with Full-WPO

BUG=490934, 617982
==========

to

==========
Disable Full-WPO for the x64 official build (non-PGO).

Disable Full-WPO for the x64 official builds (this doesn't
affect the PGO builds).


This should help me to get an official
"non-PGO & non-WPO" build that I can compare against an official PGO
build.

Also I'm not sure if it's worth keeping WPO turned on for the official
builds at the moment ? We don't ship these builds (we ship the PGO ones)
and so this only slowdown the builders that build an official x64 build
for testing purposes (especially considering that they need to link all the
unittests with Full-WPO)

BUG=490934, 617982
==========

[Sébastien Marchand, 2016-07-11 21:04:36]

On 2016/07/11 20:41:45, brucedawson wrote:
> > Because buildtype=Official imply several other things (some conditional code
> > etc), here I'm just disabling FULL WPO, the partial WPO is still enabled.
Full
> > WPO has a huge impact on the official builders that build unittests (because
> the
> > large tests take a lot of time to link with full WPO), so I'm not sure that
we
> > want to keep building a configuration that we don't ship ?
> 
> Well, either way we're building a configuration that we don't ship.
> 
> > Note that I'm doing this in order to get some non-wpo official x64 builds, I
> > could be convinced that keeping WPO for the official builds is the right
thing
> > to do :)
> 
> The title and description should be updated to make it clear that you are
> disabling full-WPO, since that is quite different from disabling WPO (which
> implies fully disabling it). Avoiding excessive build times for the unit tests
> does make sense, since we don't really benefit from the run-time improvements
> there.

Updated the definition.

[brucedawson, 2016-07-11 21:12:44]

lgtm

[Sébastien Marchand, 2016-07-11 21:15:02]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-07-11 21:15:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 01:21:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 01:21:04]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sébastien Marchand, 2016-07-12 14:26:18]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-07-12 14:27:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:38:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:38:16]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sébastien Marchand, 2016-07-12 20:05:44]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-07-12 20:08:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 23:15:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 23:15:15]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sébastien Marchand, 2016-07-13 14:59:18]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-07-13 15:00:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 15:39:36]

Description was changed from

==========
Disable Full-WPO for the x64 official build (non-PGO).

Disable Full-WPO for the x64 official builds (this doesn't
affect the PGO builds).


This should help me to get an official
"non-PGO & non-WPO" build that I can compare against an official PGO
build.

Also I'm not sure if it's worth keeping WPO turned on for the official
builds at the moment ? We don't ship these builds (we ship the PGO ones)
and so this only slowdown the builders that build an official x64 build
for testing purposes (especially considering that they need to link all the
unittests with Full-WPO)

BUG=490934, 617982
==========

to

==========
Disable Full-WPO for the x64 official build (non-PGO).

Disable Full-WPO for the x64 official builds (this doesn't
affect the PGO builds).


This should help me to get an official
"non-PGO & non-WPO" build that I can compare against an official PGO
build.

Also I'm not sure if it's worth keeping WPO turned on for the official
builds at the moment ? We don't ship these builds (we ship the PGO ones)
and so this only slowdown the builders that build an official x64 build
for testing purposes (especially considering that they need to link all the
unittests with Full-WPO)

BUG=490934, 617982
==========

[commit-bot: I haz the power, 2016-07-13 15:39:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 15:42:38]

Description was changed from

==========
Disable Full-WPO for the x64 official build (non-PGO).

Disable Full-WPO for the x64 official builds (this doesn't
affect the PGO builds).


This should help me to get an official
"non-PGO & non-WPO" build that I can compare against an official PGO
build.

Also I'm not sure if it's worth keeping WPO turned on for the official
builds at the moment ? We don't ship these builds (we ship the PGO ones)
and so this only slowdown the builders that build an official x64 build
for testing purposes (especially considering that they need to link all the
unittests with Full-WPO)

BUG=490934, 617982
==========

to

==========
Disable Full-WPO for the x64 official build (non-PGO).

Disable Full-WPO for the x64 official builds (this doesn't
affect the PGO builds).

This should help me to get an official
"non-PGO & non-WPO" build that I can compare against an official PGO
build.

Also I'm not sure if it's worth keeping WPO turned on for the official
builds at the moment ? We don't ship these builds (we ship the PGO ones)
and so this only slowdown the builders that build an official x64 build
for testing purposes (especially considering that they need to link all the
unittests with Full-WPO)

BUG=490934, 617982

Committed: https://crrev.com/0d74d7f71c93bfc3b32653de7958ff84d173937d
Cr-Commit-Position: refs/heads/master@{#405164}
==========

[commit-bot: I haz the power, 2016-07-13 15:42:39]

Patchset 1 (id:??) landed as
https://crrev.com/0d74d7f71c93bfc3b32653de7958ff84d173937d
Cr-Commit-Position: refs/heads/master@{#405164}