Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2142593003: Remove some tests that are duplicated by w3c tests. (Closed)

Created:
4 years, 5 months ago by shans
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some tests that are duplicated by w3c tests (namely those in https://github.com/w3c/web-platform-tests/tree/master/web-animations/interfaces/AnimationEffectTiming). BUG=623437 Committed: https://crrev.com/c6768d5b89fffb41077c7882095942e664860578 Cr-Commit-Position: refs/heads/master@{#405077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -154 lines) Patch
D third_party/WebKit/LayoutTests/web-animations-api/animation-constructor.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/timed-item-specified-setters.html View 1 chunk +0 lines, -118 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
shans
4 years, 5 months ago (2016-07-12 05:27:03 UTC) #2
alancutter (OOO until 2018)
The description should mention which tests are already providing this test coverage.
4 years, 5 months ago (2016-07-12 05:28:18 UTC) #3
shans
On 2016/07/12 at 05:28:18, alancutter wrote: > The description should mention which tests are already ...
4 years, 5 months ago (2016-07-12 06:17:46 UTC) #5
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-13 07:00:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142593003/1
4 years, 5 months ago (2016-07-13 07:00:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 08:15:09 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:16:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6768d5b89fffb41077c7882095942e664860578
Cr-Commit-Position: refs/heads/master@{#405077}

Powered by Google App Engine
This is Rietveld 408576698