Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2142553004: Revert of Add closure_compilation to `git cl try` for CLs that touch resources (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add closure_compilation to `git cl try` for CLs that touch resources (patchset #1 id:20001 of https://codereview.chromium.org/2129793002/ ) Reason for revert: Just use CQ dry run instead. See also, recent improvements: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/Ale4kvbwVS8/discussion Original issue's description: > Add closure_compilation to `git cl try` for CLs that touch resources > > R=dpapad@chromium.org > BUG=none > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation > NOTRY=true > > Committed: https://crrev.com/2d0143560f25e9589140c4d9198a0e5e45d02c33 > Cr-Commit-Position: refs/heads/master@{#403978} R=dpapad@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=626503 NOTRY=true Committed: https://crrev.com/7efcec187700f4868968b0087ed6d68beaab30e7 Cr-Commit-Position: refs/heads/master@{#404770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M chrome/browser/resources/PRESUBMIT.py View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/webui/resources/PRESUBMIT.py View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Dan Beam
Created Revert of Add closure_compilation to `git cl try` for CLs that touch resources
4 years, 5 months ago (2016-07-11 23:49:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142553004/1
4 years, 5 months ago (2016-07-11 23:50:11 UTC) #3
dpapad
Let's link this to BUG=626503.
4 years, 5 months ago (2016-07-11 23:54:04 UTC) #4
dpapad
lgtm
4 years, 5 months ago (2016-07-11 23:54:27 UTC) #5
Dan Beam
On 2016/07/11 23:54:04, dpapad wrote: > Let's link this to BUG=626503. Done.
4 years, 5 months ago (2016-07-11 23:55:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260429)
4 years, 5 months ago (2016-07-12 02:38:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142553004/1
4 years, 5 months ago (2016-07-12 02:48:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 02:54:25 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 02:54:50 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 02:56:06 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7efcec187700f4868968b0087ed6d68beaab30e7
Cr-Commit-Position: refs/heads/master@{#404770}

Powered by Google App Engine
This is Rietveld 408576698