Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2142553003:
Adjust the spacing between icon and text in about page (Closed)
|
Created:
4 years, 5 months ago by xiaoyinh(OOO Sep 11-29) Modified:
4 years, 5 months ago Reviewers:
xiyuan CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdjust the spacing between icon and text in about page
BUG=626267
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/8374566fb00b860f8d1d57a594c53d5ad6af3295
Cr-Commit-Position: refs/heads/master@{#405039}
Patch Set 1 #
Messages
Total messages: 25 (18 generated)
Description was changed from ========== Adjust the spacing between icon and text in about page BUG=626267 ========== to ========== Adjust the spacing between icon and text in about page BUG=626267 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Adjust the spacing between icon and text in about page BUG=626267 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Adjust the spacing between icon and text in about page BUG=626267 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
xiaoyinh@chromium.org changed reviewers: + xiyuan@chromium.org
lgtm Please check with UX with a screenshot of this CL to make sure it is okay before landing it. Thanks.
On 2016/07/12 15:44:50, xiyuan wrote: > lgtm > > Please check with UX with a screenshot of this CL to make sure it is okay before > landing it. Thanks. Confirmed with UX designer. Thanks!
The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xiaoyinh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Adjust the spacing between icon and text in about page BUG=626267 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Adjust the spacing between icon and text in about page BUG=626267 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Adjust the spacing between icon and text in about page BUG=626267 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Adjust the spacing between icon and text in about page BUG=626267 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8374566fb00b860f8d1d57a594c53d5ad6af3295 Cr-Commit-Position: refs/heads/master@{#405039} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8374566fb00b860f8d1d57a594c53d5ad6af3295 Cr-Commit-Position: refs/heads/master@{#405039} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
