Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2142523002:
Switch Mac ANGLE CQ bots to GN. (Closed)
|
Created:
4 years, 5 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 5 months ago CC:
chromium-reviews, ynovikov, Jamie Madill, Geoff Lang, Zhenyao Mo Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSwitch Mac ANGLE CQ bots to GN.
Their continued usage of GYP is causing differences between how tests
are run on Swarming compared to the Chromium CQ bots, and failures of
the WebGL 2.0 conformance tests in the new harness with the new
sharding distribution.
BUG=627158
TBR=dpranke@chromium.org
NOTRY=true
Committed: https://crrev.com/d30f809ee1bd6c06c1f5960e4a9818da17c3f233
Cr-Commit-Position: refs/heads/master@{#404712}
Patch Set 1 #
Messages
Total messages: 24 (11 generated)
kbr@chromium.org changed reviewers: + dpranke@chromium.org
FYI. CQ'ing TBR'd. This will fix the Mac bots on the ANGLE CQ and the configuration is already tested on other bots.
Description was changed from ========== Switch Mac ANGLE CQ bots to GN. Their continued usage of GYP is causing differences between how tests are run on Swarming compared to the Chromium CQ bots, and failures of the WebGL 2.0 conformance tests in the new harness with the new sharding distribution. BUG=627158 ========== to ========== Switch Mac ANGLE CQ bots to GN. Their continued usage of GYP is causing differences between how tests are run on Swarming compared to the Chromium CQ bots, and failures of the WebGL 2.0 conformance tests in the new harness with the new sharding distribution. BUG=627158 TBR=dpranke@chromium.org ==========
The CQ bit was checked by kbr@chromium.org
On 2016/07/11 at 18:33:28, kbr wrote: > FYI. CQ'ing TBR'd. This will fix the Mac bots on the ANGLE CQ and the configuration is already tested on other bots. LGTM!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jmadill@chromium.org changed reviewers: + jmadill@chromium.org
is this at all tested? i have a vague memory of asking if we can switch to gn on mac previously and being unsure.
On 2016/07/11 18:35:24, Jamie Madill wrote: > is this at all tested? i have a vague memory of asking if we can switch to gn on > mac previously and being unsure. 100% sure this is tested. mac_optional_gpu_tests_rel on the Chromium commit queue is running this configuration already.
ah yes, good point. lgtm as well.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by ynovikov@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/07/11 19:34:47, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) Unrelated; http://crbug.com/626471 . Bypassing the CQ.
The CQ bit was unchecked by kbr@chromium.org
Description was changed from ========== Switch Mac ANGLE CQ bots to GN. Their continued usage of GYP is causing differences between how tests are run on Swarming compared to the Chromium CQ bots, and failures of the WebGL 2.0 conformance tests in the new harness with the new sharding distribution. BUG=627158 TBR=dpranke@chromium.org ========== to ========== Switch Mac ANGLE CQ bots to GN. Their continued usage of GYP is causing differences between how tests are run on Swarming compared to the Chromium CQ bots, and failures of the WebGL 2.0 conformance tests in the new harness with the new sharding distribution. BUG=627158 TBR=dpranke@chromium.org NOTRY=true ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Switch Mac ANGLE CQ bots to GN. Their continued usage of GYP is causing differences between how tests are run on Swarming compared to the Chromium CQ bots, and failures of the WebGL 2.0 conformance tests in the new harness with the new sharding distribution. BUG=627158 TBR=dpranke@chromium.org NOTRY=true ========== to ========== Switch Mac ANGLE CQ bots to GN. Their continued usage of GYP is causing differences between how tests are run on Swarming compared to the Chromium CQ bots, and failures of the WebGL 2.0 conformance tests in the new harness with the new sharding distribution. BUG=627158 TBR=dpranke@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Switch Mac ANGLE CQ bots to GN. Their continued usage of GYP is causing differences between how tests are run on Swarming compared to the Chromium CQ bots, and failures of the WebGL 2.0 conformance tests in the new harness with the new sharding distribution. BUG=627158 TBR=dpranke@chromium.org NOTRY=true ========== to ========== Switch Mac ANGLE CQ bots to GN. Their continued usage of GYP is causing differences between how tests are run on Swarming compared to the Chromium CQ bots, and failures of the WebGL 2.0 conformance tests in the new harness with the new sharding distribution. BUG=627158 TBR=dpranke@chromium.org NOTRY=true Committed: https://crrev.com/d30f809ee1bd6c06c1f5960e4a9818da17c3f233 Cr-Commit-Position: refs/heads/master@{#404712} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d30f809ee1bd6c06c1f5960e4a9818da17c3f233 Cr-Commit-Position: refs/heads/master@{#404712} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
