Use initializer_lists for static WTF::HashSets.

third_party/WebKit/Source/modules/webdatabase/DatabaseAuthorizer.cpp

 /*
  * Copyright (C) 2007 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 10 matching lines @@
  * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "modules/webdatabase/DatabaseAuthorizer.h"
 
+#include "wtf/HashSet.h"
+#include "wtf/StdLibExtras.h"
+#include "wtf/text/StringHash.h"
+
 namespace blink {
 
 DatabaseAuthorizer* DatabaseAuthorizer::create(const String& databaseInfoTableName)
 {
     return new DatabaseAuthorizer(databaseInfoTableName);
 }
 
 DatabaseAuthorizer::DatabaseAuthorizer(const String& databaseInfoTableName)
     : m_securityEnabled(false)
     , m_databaseInfoTableName(databaseInfoTableName)
 {
     DCHECK(isMainThread());
 
     reset();
-    addWhitelistedFunctions();
 }
 
 void DatabaseAuthorizer::reset()
 {
     m_lastActionWasInsert = false;
     m_lastActionChangedDatabase = false;
     m_permissions = ReadWriteMask;
 }
 
 void DatabaseAuthorizer::resetDeletes()
 {
     m_hadDeletes = false;
 }
 
-void DatabaseAuthorizer::addWhitelistedFunctions()
+namespace {
+using FunctionNameList = HashSet<String, CaseFoldingHash>;
+
+const FunctionNameList& whitelistedFunctions()
 {
-    // SQLite functions used to help implement some operations
-    // ALTER TABLE helpers
-    m_whitelistedFunctions.add("sqlite_rename_table");
-    m_whitelistedFunctions.add("sqlite_rename_trigger");
-    // GLOB helpers
-    m_whitelistedFunctions.add("glob");
-
-    // SQLite core functions
-    m_whitelistedFunctions.add("abs");
-    m_whitelistedFunctions.add("changes");
-    m_whitelistedFunctions.add("coalesce");
-    m_whitelistedFunctions.add("glob");
-    m_whitelistedFunctions.add("ifnull");
-    m_whitelistedFunctions.add("hex");
-    m_whitelistedFunctions.add("last_insert_rowid");
-    m_whitelistedFunctions.add("length");
-    m_whitelistedFunctions.add("like");
-    m_whitelistedFunctions.add("lower");
-    m_whitelistedFunctions.add("ltrim");
-    m_whitelistedFunctions.add("max");
-    m_whitelistedFunctions.add("min");
-    m_whitelistedFunctions.add("nullif");
-    m_whitelistedFunctions.add("quote");
-    m_whitelistedFunctions.add("replace");
-    m_whitelistedFunctions.add("round");
-    m_whitelistedFunctions.add("rtrim");
-    m_whitelistedFunctions.add("soundex");
-    m_whitelistedFunctions.add("sqlite_source_id");
-    m_whitelistedFunctions.add("sqlite_version");
-    m_whitelistedFunctions.add("substr");
-    m_whitelistedFunctions.add("total_changes");
-    m_whitelistedFunctions.add("trim");
-    m_whitelistedFunctions.add("typeof");
-    m_whitelistedFunctions.add("upper");
-    m_whitelistedFunctions.add("zeroblob");
-
-    // SQLite date and time functions
-    m_whitelistedFunctions.add("date");
-    m_whitelistedFunctions.add("time");
-    m_whitelistedFunctions.add("datetime");
-    m_whitelistedFunctions.add("julianday");
-    m_whitelistedFunctions.add("strftime");
-
-    // SQLite aggregate functions
-    // max() and min() are already in the list
-    m_whitelistedFunctions.add("avg");
-    m_whitelistedFunctions.add("count");
-    m_whitelistedFunctions.add("group_concat");
-    m_whitelistedFunctions.add("sum");
-    m_whitelistedFunctions.add("total");
-
-    // SQLite FTS functions
-    m_whitelistedFunctions.add("match");
-    m_whitelistedFunctions.add("snippet");
-    m_whitelistedFunctions.add("offsets");
-    m_whitelistedFunctions.add("optimize");
-
-    // SQLite ICU functions
-    // like(), lower() and upper() are already in the list
-    m_whitelistedFunctions.add("regexp");
+    DEFINE_STATIC_LOCAL(FunctionNameList, list, ({
+        // SQLite functions used to help implement some operations
+        // ALTER TABLE helpers
+        "sqlite_rename_table",
+        "sqlite_rename_trigger",
+        // GLOB helpers
+        "glob",
+        // SQLite core functions
+        "abs",
+        "changes",
+        "coalesce",
+        "glob",
+        "ifnull",
+        "hex",
+        "last_insert_rowid",
+        "length",
+        "like",
+        "lower",
+        "ltrim",
+        "max",
+        "min",
+        "nullif",
+        "quote",
+        "replace",
+        "round",
+        "rtrim",
+        "soundex",
+        "sqlite_source_id",
+        "sqlite_version",
+        "substr",
+        "total_changes",
+        "trim",
+        "typeof",
+        "upper",
+        "zeroblob",
+        // SQLite date and time functions
+        "date",
+        "time",
+        "datetime",
+        "julianday",
+        "strftime",
+        // SQLite aggregate functions
+        // max() and min() are already in the list
+        "avg",
+        "count",
+        "group_concat",
+        "sum",
+        "total",
+        // SQLite FTS functions
+        "match",
+        "snippet",
+        "offsets",
+        "optimize",
+        // SQLite ICU functions
+        // like(), lower() and upper() are already in the list
+        "regexp",
+    }));
+    return list;
+}
 }
 
 int DatabaseAuthorizer::createTable(const String& tableName)
 {
     if (!allowWrite())
         return SQLAuthDeny;
 
     m_lastActionChangedDatabase = true;
     return denyBasedOnTableName(tableName);
 }
@@ skipping 234 matching lines @@
     return m_securityEnabled ? SQLAuthDeny : SQLAuthAllow;
 }
 
 int DatabaseAuthorizer::allowDetach(const String&)
 {
     return m_securityEnabled ? SQLAuthDeny : SQLAuthAllow;
 }
 
 int DatabaseAuthorizer::allowFunction(const String& functionName)
 {
-    if (m_securityEnabled && !m_whitelistedFunctions.contains(functionName))
+    if (m_securityEnabled && !whitelistedFunctions().contains(functionName))
         return SQLAuthDeny;
 
     return SQLAuthAllow;
 }
 
 void DatabaseAuthorizer::disable()
 {
     m_securityEnabled = false;
 }
 
@@ skipping 31 matching lines @@
 
 int DatabaseAuthorizer::updateDeletesBasedOnTableName(const String& tableName)
 {
     int allow = denyBasedOnTableName(tableName);
     if (allow)
         m_hadDeletes = true;
     return allow;
 }
 
 } // namespace blink