ash: Remove media dependency from ash.

ash: Remove media dependency from ash.

ash::PlaySystemSound* methods are used only from chrome. The code in ash
plays sounds through the AccessibilityDelegate interface. So remove these
methods from ash. This has two benefits: (1) ash no longer has dependency
on media, and (2) media::SoundsManager is initialized from chrome. So it
makes sense to move its usage into chrome as well.

BUG=none

Committed: https://crrev.com/cdc2bb46cfa6c22420400aa91b1b4d5d853cecef
Cr-Commit-Position: refs/heads/master@{#405231}

[sadrul, 2016-07-11 15:23:43]

sadrul@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2016-07-12 18:03:09]

oshima@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[oshima, 2016-07-12 18:03:10]

It's unfortunate to move more stuff to chrome that isn't chrome related. They're
in chrome not because it should be in chrome but because of unfortunate
dependency to chrome.

Since the direction has changed, I'm ok but want to loop in accessibility owner.
+dmazzoni@

[sadrul, 2016-07-12 18:17:18]

On 2016/07/12 18:03:10, oshima wrote:
> It's unfortunate to move more stuff to chrome that isn't chrome related.
They're
> in chrome not because it should be in chrome but because of unfortunate
> dependency to chrome.

My hope is that AccessiblityManager will move into its own component (and
mus/mojo app). This new code will also move at the same time. But until then, I
think it's good to keep the implementation in the same place (which happens to
be in chrome at the moment.)

> 
> Since the direction has changed, I'm ok but want to loop in accessibility
owner.
> +dmazzoni@

[oshima, 2016-07-12 22:05:54]

On 2016/07/12 18:17:18, sadrul wrote:
> On 2016/07/12 18:03:10, oshima wrote:
> > It's unfortunate to move more stuff to chrome that isn't chrome related.
> They're
> > in chrome not because it should be in chrome but because of unfortunate
> > dependency to chrome.
> 
> My hope is that AccessiblityManager will move into its own component (and
> mus/mojo app). This new code will also move at the same time. But until then,
I
> think it's good to keep the implementation in the same place (which happens to
> be in chrome at the moment.)

Yeah, that has been a hope :) I think it's inevitable with mus.

> > 
> > Since the direction has changed, I'm ok but want to loop in accessibility
> owner.
> > +dmazzoni@

Hmm, he's OOO. I can't think of a good reason to reject it, so lgtm.

[sadrul, 2016-07-13 00:39:08]

sadrul@chromium.org changed reviewers:
+ stevenjb@chromium.org

[sadrul, 2016-07-13 00:39:08]

stevenjb@chromium.org: Please review changes in chrome/browser/ui/webui changes.

[stevenjb, 2016-07-13 17:40:04]

c/b lgtm

[sadrul, 2016-07-13 18:38:29]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-07-13 18:39:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:45:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 19:45:26]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 19:47:27]

Description was changed from

==========
ash: Remove media dependency from ash.

ash::PlaySystemSound* methods are used only from chrome. The code in ash
plays sounds through the AccessibilityDelegate interface. So remove these
methods from ash. This has two benefits: (1) ash no longer has dependency
on media, and (2) media::SoundsManager is initialized from chrome. So it
makes sense to move its usage into chrome as well.

BUG=none
==========

to

==========
ash: Remove media dependency from ash.

ash::PlaySystemSound* methods are used only from chrome. The code in ash
plays sounds through the AccessibilityDelegate interface. So remove these
methods from ash. This has two benefits: (1) ash no longer has dependency
on media, and (2) media::SoundsManager is initialized from chrome. So it
makes sense to move its usage into chrome as well.

BUG=none

Committed: https://crrev.com/cdc2bb46cfa6c22420400aa91b1b4d5d853cecef
Cr-Commit-Position: refs/heads/master@{#405231}
==========

[commit-bot: I haz the power, 2016-07-13 19:47:29]

Patchset 2 (id:??) landed as
https://crrev.com/cdc2bb46cfa6c22420400aa91b1b4d5d853cecef
Cr-Commit-Position: refs/heads/master@{#405231}