Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 214243006: Minimal patch to add rotation to PWG raster generation (Closed)

Created:
6 years, 8 months ago by Noam Samuel
Modified:
6 years, 8 months ago
Reviewers:
Lei Zhang, gene
CC:
chromium-reviews
Visibility:
Public.

Description

Minimal patch to add rotation to PWG raster generation Add rotation to PWG raster generation. This is a minimal patch due to the requirements of having a smaller solution merged into M35. It is a slimmed down version of http://crrev.com/260694. BUG=354605 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261212

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -13 lines) Patch
M chrome/utility/chrome_content_utility_client.cc View 1 2 chunks +10 lines, -1 line 0 comments Download
M chrome/utility/cloud_print/pwg_encoder.h View 1 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/utility/cloud_print/pwg_encoder.cc View 1 3 chunks +23 lines, -6 lines 0 comments Download
M chrome/utility/cloud_print/pwg_encoder_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Noam Samuel
6 years, 8 months ago (2014-04-02 22:21:49 UTC) #1
Lei Zhang
chrome_content_utility_client.cc lgtm
6 years, 8 months ago (2014-04-02 22:26:15 UTC) #2
Noam Samuel
On 2014/04/02 22:26:15, Lei Zhang wrote: > chrome_content_utility_client.cc lgtm Gene: Minimized patch further
6 years, 8 months ago (2014-04-02 22:48:55 UTC) #3
gene
lgtm
6 years, 8 months ago (2014-04-02 23:04:04 UTC) #4
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 8 months ago (2014-04-02 23:04:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/214243006/20001
6 years, 8 months ago (2014-04-02 23:04:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 23:05:09 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/utility/chrome_content_utility_client.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-02 23:05:11 UTC) #8
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 8 months ago (2014-04-02 23:06:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/214243006/20001
6 years, 8 months ago (2014-04-02 23:09:00 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 23:12:35 UTC) #11
Message was sent while issue was closed.
Change committed as 261212

Powered by Google App Engine
This is Rietveld 408576698