content/browser/accessibility/browser_accessibility_manager.cc - Issue 214243005: Fire accessibility focus/blur events on root web document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager.cc

Issue 214243005: Fire accessibility focus/blur events on root web document. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fire event before fullscreen check destroys window Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.h ('k') | content/browser/accessibility/browser_accessibility_manager_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager.cc b/content/browser/accessibility/browser_accessibility_manager.cc

index 8481b0776c42c9ee6df90e205de097b0e3a6db35..26b005c04e81f281ce5915470505e0861014b656 100644

--- a/content/browser/accessibility/browser_accessibility_manager.cc

+++ b/content/browser/accessibility/browser_accessibility_manager.cc

@@ -86,18 +86,14 @@ BrowserAccessibility* BrowserAccessibilityManager::GetFromRendererID(

return NULL;

}

-void BrowserAccessibilityManager::GotFocus(bool touch_event_context) {

- if (!touch_event_context)

- osk_state_ = OSK_DISALLOWED_BECAUSE_TAB_JUST_APPEARED;

- if (!focus_)

- return;

- NotifyAccessibilityEvent(ui::AX_EVENT_FOCUS, focus_);

+void BrowserAccessibilityManager::OnWindowFocused() {

+ if (focus_)

+ NotifyAccessibilityEvent(ui::AX_EVENT_FOCUS, focus_);

}

-void BrowserAccessibilityManager::WasHidden() {

- osk_state_ = OSK_DISALLOWED_BECAUSE_TAB_HIDDEN;

+void BrowserAccessibilityManager::OnWindowBlurred() {

+ if (focus_)

+ NotifyAccessibilityEvent(ui::AX_EVENT_BLUR, focus_);

}

void BrowserAccessibilityManager::GotMouseDown() {