Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 214243004: Remove dead code in ports/. (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove dead code in ports/. These files are not referenced by any .gyp file in Skia or Chromium. ninja -C out/Debug everything still builds. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -622 lines) Patch
D src/ports/SkHarfBuzzFont.cpp View 1 chunk +0 lines, -182 lines 0 comments Download
D src/ports/SkXMLParser_expat.cpp View 1 chunk +0 lines, -140 lines 0 comments Download
D src/ports/SkXMLParser_tinyxml.cpp View 1 chunk +0 lines, -87 lines 0 comments Download
D src/ports/SkXMLPullParser_expat.cpp View 1 chunk +0 lines, -213 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
6 years, 8 months ago (2014-04-02 20:14:17 UTC) #1
bungeman-skia
I have a CL out there that I haven't had time to work on, https://codereview.chromium.org/23137018/ ...
6 years, 8 months ago (2014-04-02 20:18:57 UTC) #2
mtklein
Hal's feeling brave!
6 years, 8 months ago (2014-04-02 20:29:32 UTC) #3
hal.canary
lgtm
6 years, 8 months ago (2014-04-02 20:30:27 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-02 20:30:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/214243004/1
6 years, 8 months ago (2014-04-02 20:30:51 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 22:03:24 UTC) #7
Message was sent while issue was closed.
Change committed as 14036

Powered by Google App Engine
This is Rietveld 408576698