Remove some chrome dependencies from extensions app_window API

Remove some chrome dependencies from extensions app_window API

This is a step toward moving it into //apps where it can be used by app_shell

BUG=359126
TEST=browser_tests PlatformApp*
TBR=miket@chromium.org for DEPS

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261501

[James Cook, 2014-04-02 20:15:47]

scheib, PTAL

https://codereview.chromium.org/214243003/diff/1/extensions/browser/DEPS
File extensions/browser/DEPS (right):

https://codereview.chromium.org/214243003/diff/1/extensions/browser/DEPS#newc...
extensions/browser/DEPS:8: "+third_party/skia/include",
//extensions already depends on skia elsewhere (see //extensions/extensions.gyp)
so I think this is OK.

https://codereview.chromium.org/214243003/diff/1/extensions/browser/image_util.h
File extensions/browser/image_util.h (right):

https://codereview.chromium.org/214243003/diff/1/extensions/browser/image_uti...
extensions/browser/image_util.h:5: #ifndef EXTENSIONS_BROWSER_IMAGE_UTIL_H_
This file is called image_util.h instead of color_util.h because I anticipate
more image-related utility functions (for window icons, extension icons, etc.)
to move here soon.

[scheib, 2014-04-02 20:45:21]

lgtm

https://codereview.chromium.org/214243003/diff/1/extensions/browser/DEPS
File extensions/browser/DEPS (right):

https://codereview.chromium.org/214243003/diff/1/extensions/browser/DEPS#newc...
extensions/browser/DEPS:8: "+third_party/skia/include",
On 2014/04/02 20:15:47, James Cook wrote:
> //extensions already depends on skia elsewhere (see
//extensions/extensions.gyp)
> so I think this is OK.

Hmm, I guess so, but then why doesn't code search show a DEPS file with skia?
https://code.google.com/p/chromium/codesearch#search/&type=cs&q=skia%20packag...

[James Cook, 2014-04-02 21:49:33]

I think it actually comes in through generated API/schema files, which won't
show up in DEPS since they aren't part of the files in the checkout.

Here's the actual dependency:
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...

[James Cook, 2014-04-03 00:19:06]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-04-03 00:22:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/214243003/1

[commit-bot: I haz the power, 2014-04-03 08:32:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 08:32:55]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[scheib, 2014-04-03 13:41:05]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2014-04-03 13:41:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/214243003/1

[commit-bot: I haz the power, 2014-04-03 14:19:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 14:19:20]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[James Cook, 2014-04-03 16:01:24]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-04-03 16:01:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/214243003/1

[commit-bot: I haz the power, 2014-04-03 19:20:31]

Change committed as 261501