Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2328)

Unified Diff: build/android/gyp/javac.py

Issue 2142413004: Add required deps to third_party/android_support_test_runner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated android_support_test_runner to use third_party/junit Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/android/internal_rules.gni » ('j') | build/config/android/internal_rules.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/javac.py
diff --git a/build/android/gyp/javac.py b/build/android/gyp/javac.py
index c8425bd3aa578880d0b88f46440569c97670b589..f475043c6143a400e5028bf49543df01a37f8a0e 100755
--- a/build/android/gyp/javac.py
+++ b/build/android/gyp/javac.py
@@ -257,6 +257,11 @@ def _ParseOptions(argv):
help='Boot classpath for javac. If this is specified multiple times, '
'they will all be appended to construct the classpath.')
parser.add_option(
mikecase (-- gone --) 2016/08/22 23:42:17 If you take my suggestions to internal_rules.gni,
aluo 2016/08/23 00:37:57 There's logic in this script to set -src and -targ
+ '--use_host_bootclasspath',
mikecase (-- gone --) 2016/08/22 23:42:17 --use-host-bootclasspath
aluo 2016/08/23 00:37:57 Acknowledged.
+ type='int',
mikecase (-- gone --) 2016/08/22 23:42:17 Remove type='int' Instead just action="store_true
aluo 2016/08/23 00:37:57 Acknowledged.
+ help='Do not use custom bootclasspath even if bootclasspath is '
+ 'specified.')
mikecase (-- gone --) 2016/08/22 23:42:17 indenting (should be aligned with text above)
aluo 2016/08/23 00:37:57 Acknowledged.
+ parser.add_option(
'--classpath',
action='append',
help='Classpath for javac. If this is specified multiple times, they '
@@ -378,8 +383,11 @@ def main(argv):
))
if options.bootclasspath:
+ if not options.use_host_bootclasspath:
+ javac_cmd.extend([
+ '-bootclasspath', ':'.join(options.bootclasspath)
+ ])
javac_cmd.extend([
- '-bootclasspath', ':'.join(options.bootclasspath),
'-source', '1.7',
'-target', '1.7',
])
« no previous file with comments | « no previous file | build/config/android/internal_rules.gni » ('j') | build/config/android/internal_rules.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698