Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 2142413003: Adding Discarded property support for onUpdate function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@API_Discarded
Patch Set: nit fixed Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_apitest.h" 5 #include "chrome/browser/extensions/extension_apitest.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "chrome/browser/prefs/incognito_mode_prefs.h" 8 #include "chrome/browser/prefs/incognito_mode_prefs.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 270
271 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedPopup) { 271 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedPopup) {
272 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html")) 272 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html"))
273 << message_; 273 << message_;
274 } 274 }
275 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) { 275 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) {
276 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html")) 276 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))
277 << message_; 277 << message_;
278 } 278 }
279 279
280 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DiscardedState) {
281 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "discarded.html")) << message_;
282 }
283
280 // Adding a new test? Awesome. But API tests are the old hotness. The new 284 // Adding a new test? Awesome. But API tests are the old hotness. The new
281 // hotness is extension_function_test_utils. See tabs_test.cc for an example. 285 // hotness is extension_function_test_utils. See tabs_test.cc for an example.
282 // We are trying to phase out many uses of API tests as they tend to be flaky. 286 // We are trying to phase out many uses of API tests as they tend to be flaky.
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_event_router.cc ('k') | chrome/common/extensions/api/tabs.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698