Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2142403002: Pick up starting position from OpenSLES getPosition(). (Closed)

Created:
4 years, 5 months ago by DaleCurtis
Modified:
4 years, 5 months ago
Reviewers:
watk
CC:
avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pick up starting position from OpenSLES getPosition(). On older versions of Android it looks like getPosition() does not return to zero after Clear() is called; so we must pick up the initial position returned from getPosition() in order to calculate the delay for our audio stream. For posterity, I tried calling ClearMarkerPosition(), SetPositionUpdatePeriod(), and various contortions of using the returned position without any success. Including continuing to use the last known position if the starting-position is non-zero. BUG=627259 TEST=no dcheck. Committed: https://crrev.com/9ed5f67fdb5b313f3d26e612615ae4812f411620 Cr-Commit-Position: refs/heads/master@{#405329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M media/audio/android/opensles_output.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
DaleCurtis
4 years, 5 months ago (2016-07-13 01:38:30 UTC) #2
watk
lgtm
4 years, 5 months ago (2016-07-13 20:19:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142403002/1
4 years, 5 months ago (2016-07-13 20:51:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 22:54:16 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 22:54:23 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 22:57:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ed5f67fdb5b313f3d26e612615ae4812f411620
Cr-Commit-Position: refs/heads/master@{#405329}

Powered by Google App Engine
This is Rietveld 408576698