Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2142393003: handle large conic weights (Closed)

Created:
4 years, 5 months ago by reed1
Modified:
4 years, 5 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Patch Set 3 : fix double-float warning #

Patch Set 4 : replace assert with REPORTER_ASSERT #

Patch Set 5 : another double warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1 line) Patch
M include/core/SkPoint.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkGeometry.cpp View 1 1 chunk +10 lines, -1 line 0 comments Download
M tests/GeometryTest.cpp View 1 2 3 4 2 chunks +40 lines, -0 lines 0 comments Download
M tests/PathTest.cpp View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
reed1
4 years, 5 months ago (2016-07-13 15:28:27 UTC) #5
caryclark
lgtm https://codereview.chromium.org/2142393003/diff/1/src/core/SkGeometry.cpp File src/core/SkGeometry.cpp (right): https://codereview.chromium.org/2142393003/diff/1/src/core/SkGeometry.cpp#newcode1180 src/core/SkGeometry.cpp:1180: // as our first and last are already ...
4 years, 5 months ago (2016-07-13 15:33:37 UTC) #9
reed1
https://codereview.chromium.org/2142393003/diff/1/src/core/SkGeometry.cpp File src/core/SkGeometry.cpp (right): https://codereview.chromium.org/2142393003/diff/1/src/core/SkGeometry.cpp#newcode1180 src/core/SkGeometry.cpp:1180: // as our first and last are already on ...
4 years, 5 months ago (2016-07-13 15:55:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142393003/40001
4 years, 5 months ago (2016-07-13 15:55:39 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/9635) Build-Ubuntu-GCC-x86_64-Release-Trybot on master.client.skia.compile (JOB_FAILED, ...
4 years, 5 months ago (2016-07-13 16:01:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142393003/80001
4 years, 5 months ago (2016-07-13 17:42:39 UTC) #25
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:56:56 UTC) #27
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/b1b12f8666a48b8ff1367beed97bc84032552ac8

Powered by Google App Engine
This is Rietveld 408576698