Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2142393002: Add perf tests for async waits using base::MessageLoop. (Closed)

Created:
4 years, 5 months ago by viettrungluu
Modified:
4 years, 5 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work791_async_waiter_perftest
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add perf tests for async waits using base::MessageLoop. (Using both the default MessagePump and MessagePumpMojo.) Current results (done haphazardly: Release build on my non-quiescent Z620) are suitably poor: AsyncWaitPerfTest.SingleThreaded_DefaultMessagePump/1 74992.5 callbacks/second AsyncWaitPerfTest.SingleThreaded_DefaultMessagePump/10 65747.5 callbacks/second AsyncWaitPerfTest.SingleThreaded_DefaultMessagePump/100 34570 callbacks/second AsyncWaitPerfTest.SingleThreaded_DefaultMessagePump/1000 6528.58 callbacks/second AsyncWaitPerfTest.SingleThreaded_DefaultMessagePump/10000 913.65 callbacks/second AsyncWaitPerfTest.SingleThreaded_MessagePumpMojo/1 799942 callbacks/second AsyncWaitPerfTest.SingleThreaded_MessagePumpMojo/10 465479 callbacks/second AsyncWaitPerfTest.SingleThreaded_MessagePumpMojo/100 90049.3 callbacks/second AsyncWaitPerfTest.SingleThreaded_MessagePumpMojo/1000 7595.61 callbacks/second AsyncWaitPerfTest.SingleThreaded_MessagePumpMojo/10000 976.549 callbacks/second R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/20370a4fefe605a905c9cf3dfa07c082bcb98c81

Patch Set 1 #

Patch Set 2 : gah #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -1 line) Patch
M mojo/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/environment/BUILD.gn View 1 2 chunks +24 lines, -0 lines 0 comments Download
A mojo/environment/async_wait_perftest.cc View 1 chunk +78 lines, -0 lines 0 comments Download
M mojo/tools/get_test_list.py View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2141083003 Patch 20001

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 5 months ago (2016-07-13 01:02:53 UTC) #1
viettrungluu
4 years, 5 months ago (2016-07-13 01:07:21 UTC) #2
vardhan
lgtm
4 years, 5 months ago (2016-07-13 19:21:09 UTC) #3
viettrungluu
4 years, 5 months ago (2016-07-13 20:54:11 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
20370a4fefe605a905c9cf3dfa07c082bcb98c81 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698