third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp - Issue 2142373002: Make v8AtomicString take a StringView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

Issue 2142373002: Make v8AtomicString take a StringView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Woops, pass the length. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

index c6cb29661fc2cab3797a97d98c6bc06d8cc97012..a8d4be011e9c99e2e3dd5ae22c0b877b6ee463d1 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

@@ -466,10 +466,9 @@ void WindowProxy::setSecurityToken(SecurityOrigin* origin)

token = frameSecurityToken + token;

}

- CString utf8Token = token.utf8();

// NOTE: V8 does identity comparison in fast path, must use a symbol

// as the security token.

- context->SetSecurityToken(v8AtomicString(m_isolate, utf8Token.data(), utf8Token.length()));

+ context->SetSecurityToken(v8AtomicString(m_isolate, token));

}

void WindowProxy::updateDocument()