third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp - Issue 2142373002: Make v8AtomicString take a StringView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp

Issue 2142373002: Make v8AtomicString take a StringView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Woops, pass the length. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp

index 88d109613e30b4364a4f6e7020dee81210f0138f..895dab34faf786d1d7c4ce58979d9bc398bbe805 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp

@@ -1626,7 +1626,7 @@ bool SerializedScriptValueReader::readString(v8::Local<v8::Value>* value)

return false;

if (m_position + length > m_length)

return false;

- *value = v8AtomicString(isolate(), reinterpret_cast<const char*>(m_buffer + m_position), length);

+ *value = v8StringFromUtf8(isolate(), reinterpret_cast<const char*>(m_buffer + m_position), length);

m_position += length;

return true;

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »