Make v8AtomicString take a StringView.

third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 174 matching lines @@
 }
 
 void CryptoResultImpl::completeWithJson(const char* utf8Data, unsigned length)
 {
     if (!m_resolver)
         return;
 
     ScriptState* scriptState = m_resolver->getScriptState();
     ScriptState::Scope scope(scriptState);
 
-    v8::Local<v8::String> jsonString = v8AtomicString(scriptState->isolate(), utf8Data, length);
+    v8::Local<v8::String> jsonString = v8StringFromUtf8(scriptState->isolate(), utf8Data, length);

[haraken, 2016/07/13 01:12:49]

Can we use v8AtomicString(..., StringView(utf8Data))?

I'm not really happy about introducing v8StringFromUtf8 since it shouldn't be
encouraged.

[esprehn, 2016/07/13 01:50:30]

That would mangle the utf8 data which needs to be inflated to utf16 if it
contains anything outside latin1. StringView can also only be latin1 or utf16
just like StringImpl, there's no way to put utf8 data into it without doing a
conversion. We could do that conversion but it's kind of wasteful since v8 can
do it for us internally without the extra copy.
Just like people don't use String::fromUTF8 very much I'm hopeful they won't use
this either.

 
     v8::TryCatch exceptionCatcher(scriptState->isolate());
     v8::Local<v8::Value> jsonDictionary;
     if (v8Call(v8::JSON::Parse(scriptState->isolate(), jsonString), jsonDictionary, exceptionCatcher))
         m_resolver->resolve(jsonDictionary);
     else
         m_resolver->reject(exceptionCatcher.Exception());
     clearResolver();
 }
 
@@ skipping 39 matching lines @@
     m_cancel.clear();
     clearResolver();
 }
 
 ScriptPromise CryptoResultImpl::promise()
 {
     return m_resolver ? m_resolver->promise() : ScriptPromise();
 }
 
 } // namespace blink