Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2142353004: Switch all buildbots to GN build (Closed)

Created:
4 years, 5 months ago by Wei Li
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, Paweł Hajdan Jr.
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Switch all buildbots to GN build Make all builtbots to use GN by default, except keeping a few legacy GYP builds around until Chrome stops using GYP bots. Also use 64 bit compilation by default on Windows. Use 'GYP_PDFIUM_NO_ACTION' to skip running GYP script for GN builds. BUG=pdfium:484 Committed: https://chromium.googlesource.com/chromium/tools/build/+/fc16c93284613da91ac72554535b71425589d07e

Patch Set 1 #

Patch Set 2 : skip gyp action #

Patch Set 3 : order by builder names #

Patch Set 4 : small fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+595 lines, -1808 lines) Patch
M masters/master.client.pdfium/builders.pyl View 1 2 3 4 chunks +83 lines, -77 lines 0 comments Download
M masters/master.tryserver.client.pdfium/builders.pyl View 1 2 7 chunks +46 lines, -54 lines 0 comments Download
M scripts/slave/recipes/pdfium.py View 1 10 chunks +99 lines, -88 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/android.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/drm_win_xfa.json View 1 3 chunks +15 lines, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux.json View 1 3 chunks +15 lines, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_asan.json View 1 3 chunks +15 lines, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_no_v8.json View 1 4 chunks +16 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_skia.json View 1 2 chunks +14 lines, -0 lines 0 comments Download
D scripts/slave/recipes/pdfium.expected/linux_skia_gn.json View 1 chunk +0 lines, -90 lines 0 comments Download
A + scripts/slave/recipes/pdfium.expected/linux_skia_gyp.json View 2 chunks +2 lines, -16 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa.json View 1 3 chunks +15 lines, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa_asan.json View 1 3 chunks +15 lines, -1 line 0 comments Download
D scripts/slave/recipes/pdfium.expected/linux_xfa_debug_gn.json View 1 chunk +0 lines, -137 lines 0 comments Download
A + scripts/slave/recipes/pdfium.expected/linux_xfa_gyp.json View 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json View 1 3 chunks +15 lines, -1 line 0 comments Download
D scripts/slave/recipes/pdfium.expected/linux_xfa_rel_gn.json View 1 chunk +0 lines, -137 lines 0 comments Download
A + scripts/slave/recipes/pdfium.expected/linux_xfa_rel_gyp.json View 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac.json View 1 3 chunks +15 lines, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_no_v8.json View 1 4 chunks +16 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_skia.json View 1 2 chunks +14 lines, -0 lines 0 comments Download
D scripts/slave/recipes/pdfium.expected/mac_skia_gn.json View 1 chunk +0 lines, -90 lines 0 comments Download
A + scripts/slave/recipes/pdfium.expected/mac_skia_gyp.json View 2 chunks +2 lines, -16 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_xfa.json View 1 3 chunks +15 lines, -1 line 0 comments Download
D scripts/slave/recipes/pdfium.expected/mac_xfa_debug_gn.json View 1 chunk +0 lines, -137 lines 0 comments Download
A + scripts/slave/recipes/pdfium.expected/mac_xfa_gyp.json View 3 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
D scripts/slave/recipes/pdfium.expected/mac_xfa_rel_gn.json View 1 chunk +0 lines, -137 lines 0 comments Download
A + scripts/slave/recipes/pdfium.expected/mac_xfa_rel_gyp.json View 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan.json View 1 7 chunks +31 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win.json View 1 3 chunks +15 lines, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_no_v8.json View 1 4 chunks +16 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_skia.json View 1 2 chunks +14 lines, -0 lines 0 comments Download
D scripts/slave/recipes/pdfium.expected/win_skia_gn.json View 1 chunk +0 lines, -90 lines 0 comments Download
A + scripts/slave/recipes/pdfium.expected/win_skia_gyp.json View 2 chunks +2 lines, -16 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa.json View 1 3 chunks +15 lines, -1 line 0 comments Download
A + scripts/slave/recipes/pdfium.expected/win_xfa_32.json View 1 7 chunks +11 lines, -11 lines 0 comments Download
D scripts/slave/recipes/pdfium.expected/win_xfa_64.json View 1 chunk +0 lines, -123 lines 0 comments Download
D scripts/slave/recipes/pdfium.expected/win_xfa_64_debug_gn.json View 1 chunk +0 lines, -137 lines 0 comments Download
D scripts/slave/recipes/pdfium.expected/win_xfa_64_rel.json View 1 chunk +0 lines, -123 lines 0 comments Download
D scripts/slave/recipes/pdfium.expected/win_xfa_64_rel_gn.json View 1 chunk +0 lines, -137 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_clang.json View 1 3 chunks +15 lines, -1 line 0 comments Download
A + scripts/slave/recipes/pdfium.expected/win_xfa_clang_32.json View 1 6 chunks +23 lines, -9 lines 0 comments Download
D scripts/slave/recipes/pdfium.expected/win_xfa_clang_x64.json View 1 chunk +0 lines, -123 lines 0 comments Download
A + scripts/slave/recipes/pdfium.expected/win_xfa_gyp.json View 6 chunks +8 lines, -8 lines 0 comments Download
A + scripts/slave/recipes/pdfium.expected/win_xfa_rel.json View 1 7 chunks +10 lines, -10 lines 0 comments Download
A + scripts/slave/recipes/pdfium.expected/win_xfa_rel_gyp.json View 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Wei Li
pls review, thanks
4 years, 5 months ago (2016-07-13 21:31:47 UTC) #4
Dirk Pranke
lgtm, though this is kind of a hard CL to review and I wouldn't be ...
4 years, 5 months ago (2016-07-13 23:01:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142353004/60001
4 years, 5 months ago (2016-07-14 04:34:40 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/tools/build/+/fc16c93284613da91ac72554535b71425589d07e
4 years, 5 months ago (2016-07-14 04:39:24 UTC) #10
Lei Zhang
Do we need a restart after this? https://codereview.chromium.org/2149773003/ has purple bots. CC trooper.
4 years, 5 months ago (2016-07-14 06:35:28 UTC) #12
Dirk Pranke
4 years, 5 months ago (2016-07-14 16:25:21 UTC) #13
Message was sent while issue was closed.
On 2016/07/14 06:35:28, Lei Zhang (Slow Thursday) wrote:
> Do we need a restart after this? https://codereview.chromium.org/2149773003/
has
> purple bots.
> 
> CC trooper.

Yes, this needs a restart.

Powered by Google App Engine
This is Rietveld 408576698