gpu/command_buffer/service/framebuffer_manager_unittest.cc - Issue 2142353002: Validate fbo color image format and fragment shader output variable type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/framebuffer_manager_unittest.cc

Issue 2142353002: Validate fbo color image format and fragment shader output variable type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Validate fbo color image format and fragment shader output variable type. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/framebuffer_manager.cc ('K') | « gpu/command_buffer/service/framebuffer_manager.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/framebuffer_manager_unittest.cc

diff --git a/gpu/command_buffer/service/framebuffer_manager_unittest.cc b/gpu/command_buffer/service/framebuffer_manager_unittest.cc

index fef4b6e412e2f12bb6439a6f53bf0d3e799b1897..d7ad95709264c1e6daaf84b8c123205144ca2054 100644

--- a/gpu/command_buffer/service/framebuffer_manager_unittest.cc

+++ b/gpu/command_buffer/service/framebuffer_manager_unittest.cc

@@ -1071,7 +1071,8 @@ TEST_F(FramebufferInfoTest, DrawBuffers) {

EXPECT_CALL(*gl_, DrawBuffersARB(kMaxDrawBuffers, _))

.Times(1)

.RetiresOnSaturation();

- EXPECT_TRUE(framebuffer_->PrepareDrawBuffersForClear());

+ EXPECT_TRUE(

+ framebuffer_->PrepareDrawBuffersForClearingUninitializedAttachments());

// Now we disable draw buffer 1.

buffers[1] = GL_NONE;

@@ -1081,14 +1082,16 @@ TEST_F(FramebufferInfoTest, DrawBuffers) {

EXPECT_CALL(*gl_, DrawBuffersARB(kMaxDrawBuffers, _))

.Times(1)

.RetiresOnSaturation();

- EXPECT_TRUE(framebuffer_->PrepareDrawBuffersForClear());

+ EXPECT_TRUE(

+ framebuffer_->PrepareDrawBuffersForClearingUninitializedAttachments());

// Now we disable draw buffer 0, enable draw buffer 1.

buffers[0] = GL_NONE;

buffers[1] = GL_COLOR_ATTACHMENT1;

framebuffer_->SetDrawBuffers(2, buffers);

// This is the perfect setting for clear. No need to call DrawBuffers().

- EXPECT_FALSE(framebuffer_->PrepareDrawBuffersForClear());

+ EXPECT_FALSE(

+ framebuffer_->PrepareDrawBuffersForClearingUninitializedAttachments());

}

class FramebufferInfoFloatTest : public FramebufferInfoTest {