Validate fbo color image format and fragment shader output variable type.

gpu/command_buffer/service/program_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/program_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 41 matching lines @@
   return static_cast<const uint8_t*>(position) -
          static_cast<const uint8_t*>(start);
 }
 
 }  // namespace anonymous
 
 class ProgramManagerTestBase : public GpuServiceTest {
  protected:
   virtual void SetupProgramManager() {
     manager_.reset(new ProgramManager(nullptr, kMaxVaryingVectors,
+                                      kMaxDrawBuffers,
                                       kMaxDualSourceDrawBuffers,
                                       gpu_preferences_,
                                       feature_info_.get()));
   }
   void SetUpBase(const char* gl_version,
                  const char* gl_extensions,
                  FeatureInfo* feature_info = nullptr) {
     GpuServiceTest::SetUpWithGLVersion(gl_version, gl_extensions);
     TestHelper::SetupFeatureInfoInitExpectationsWithGLVersion(
         gl_.get(), gl_extensions, "", gl_version);
@@ skipping 1664 matching lines @@
   Program* program =
       SetupProgramForVariables(&kVertexAttribute, 1, &kFragmentUniform, 1);
 
   std::string conflicting_name;
 
   EXPECT_TRUE(program->DetectGlobalNameConflicts(&conflicting_name));
   EXPECT_EQ("a", conflicting_name);
   EXPECT_TRUE(LinkAsExpected(program, false));
 }
 
+TEST_F(ProgramManagerWithShaderTest, FragmentOutputTypes) {
+  // Set up program
+  Shader* vshader = shader_manager_.CreateShader(
+      kVertexShaderClientId, kVertexShaderServiceId, GL_VERTEX_SHADER);
+  TestHelper::SetShaderStates(gl_.get(), vshader, true, nullptr, nullptr,
+                              nullptr, nullptr, nullptr, nullptr, nullptr,
+                              nullptr, nullptr);
+  Shader* fshader = shader_manager_.CreateShader(
+      kFragmentShaderClientId, kFragmentShaderServiceId, GL_FRAGMENT_SHADER);
+  ASSERT_TRUE(vshader && fshader);
+  Program* program =
+      manager_->CreateProgram(kClientProgramId, kServiceProgramId);
+  ASSERT_TRUE(program);
+  EXPECT_TRUE(program->AttachShader(&shader_manager_, vshader));
+  EXPECT_TRUE(program->AttachShader(&shader_manager_, fshader));
+
+  {  // No outputs.
+    TestHelper::SetShaderStates(gl_.get(), fshader, true, nullptr, nullptr,
+                                nullptr, nullptr, nullptr, nullptr, nullptr,
+                                nullptr, nullptr);
+    EXPECT_TRUE(LinkAsExpected(program, true));
+    EXPECT_EQ(0u, program->fragment_output_type_mask());
+    EXPECT_EQ(0u, program->fragment_output_written_mask());
+  }
+
+  {  // gl_FragColor
+    OutputVariableList fragment_outputs;
+    sh::OutputVariable var = TestHelper::ConstructOutputVariable(
+        GL_FLOAT_VEC4, 0, GL_MEDIUM_FLOAT, true, "gl_FragColor");
+    var.location = -1;
+    fragment_outputs.push_back(var);
+    TestHelper::SetShaderStates(gl_.get(), fshader, true, nullptr, nullptr,
+                                nullptr, nullptr, nullptr, nullptr, nullptr,
+                                &fragment_outputs, nullptr);
+    EXPECT_TRUE(LinkAsExpected(program, true));
+    EXPECT_EQ(0x3u, program->fragment_output_type_mask());
+    EXPECT_EQ(0x3u, program->fragment_output_written_mask());
+  }
+
+  {  // gl_FragData
+    OutputVariableList fragment_outputs;
+    sh::OutputVariable var = TestHelper::ConstructOutputVariable(
+        GL_FLOAT_VEC4, 8, GL_MEDIUM_FLOAT, true, "gl_FragData");
+    var.location = -1;
+    fragment_outputs.push_back(var);
+    TestHelper::SetShaderStates(gl_.get(), fshader, true, nullptr, nullptr,
+                                nullptr, nullptr, nullptr, nullptr, nullptr,
+                                &fragment_outputs, nullptr);
+    EXPECT_TRUE(LinkAsExpected(program, true));
+    EXPECT_EQ(0xFFFFu, program->fragment_output_type_mask());
+    EXPECT_EQ(0xFFFFu, program->fragment_output_written_mask());
+  }
+
+  {  // gl_FragColor, gl_FragDepth
+    OutputVariableList fragment_outputs;
+    sh::OutputVariable var = TestHelper::ConstructOutputVariable(
+        GL_FLOAT_VEC4, 0, GL_MEDIUM_FLOAT, true, "gl_FragColor");
+    var.location = -1;
+    fragment_outputs.push_back(var);
+    var = TestHelper::ConstructOutputVariable(
+        GL_FLOAT, 0, GL_MEDIUM_FLOAT, true, "gl_FragDepth");
+    var.location = -1;
+    fragment_outputs.push_back(var);
+    TestHelper::SetShaderStates(gl_.get(), fshader, true, nullptr, nullptr,
+                                nullptr, nullptr, nullptr, nullptr, nullptr,
+                                &fragment_outputs, nullptr);
+    EXPECT_TRUE(LinkAsExpected(program, true));
+    EXPECT_EQ(0x3u, program->fragment_output_type_mask());
+    EXPECT_EQ(0x3u, program->fragment_output_written_mask());
+  }
+
+  {  // Single user defined output.
+    OutputVariableList fragment_outputs;
+    sh::OutputVariable var = TestHelper::ConstructOutputVariable(
+        GL_UNSIGNED_INT_VEC4, 0, GL_MEDIUM_INT, true, "myOutput");
+    var.location = -1;
+    fragment_outputs.push_back(var);
+    TestHelper::SetShaderStates(gl_.get(), fshader, true, nullptr, nullptr,
+                                nullptr, nullptr, nullptr, nullptr, nullptr,
+                                &fragment_outputs, nullptr);
+    EXPECT_TRUE(LinkAsExpected(program, true));
+    EXPECT_EQ(0x2u, program->fragment_output_type_mask());
+    EXPECT_EQ(0x3u, program->fragment_output_written_mask());
+  }
+
+  {  // Single user defined output - no static use.
+    OutputVariableList fragment_outputs;
+    sh::OutputVariable var = TestHelper::ConstructOutputVariable(
+        GL_UNSIGNED_INT_VEC4, 0, GL_MEDIUM_INT, false, "myOutput");
+    var.location = -1;
+    fragment_outputs.push_back(var);
+    TestHelper::SetShaderStates(gl_.get(), fshader, true, nullptr, nullptr,
+                                nullptr, nullptr, nullptr, nullptr, nullptr,
+                                &fragment_outputs, nullptr);
+    EXPECT_TRUE(LinkAsExpected(program, true));
+    EXPECT_EQ(0x2u, program->fragment_output_type_mask());
+    EXPECT_EQ(0x3u, program->fragment_output_written_mask());
+  }
+
+  {  // Multiple user defined outputs.
+    OutputVariableList fragment_outputs;
+    sh::OutputVariable var = TestHelper::ConstructOutputVariable(
+        GL_INT_VEC4, 0, GL_MEDIUM_INT, true, "myOutput");
+    var.location = 0;
+    fragment_outputs.push_back(var);
+    var = TestHelper::ConstructOutputVariable(
+        GL_FLOAT_VEC4, 2, GL_MEDIUM_FLOAT, true, "myOutputArray");
+    var.location = 2;
+    fragment_outputs.push_back(var);
+    TestHelper::SetShaderStates(gl_.get(), fshader, true, nullptr, nullptr,
+                                nullptr, nullptr, nullptr, nullptr, nullptr,
+                                &fragment_outputs, nullptr);
+    EXPECT_TRUE(LinkAsExpected(program, true));
+    EXPECT_EQ(0xF1u, program->fragment_output_type_mask());
+    EXPECT_EQ(0xF3u, program->fragment_output_written_mask());
+  }
+}
+
 // Varyings go over 8 rows.
 TEST_F(ProgramManagerWithShaderTest, TooManyVaryings) {
   const VarInfo kVertexVaryings[] = {
       { GL_FLOAT_VEC4, 4, GL_MEDIUM_FLOAT, true, "a", kVarVarying },
       { GL_FLOAT_VEC4, 5, GL_MEDIUM_FLOAT, true, "b", kVarVarying }
   };
   const VarInfo kFragmentVaryings[] = {
       { GL_FLOAT_VEC4, 4, GL_MEDIUM_FLOAT, true, "a", kVarVarying },
       { GL_FLOAT_VEC4, 5, GL_MEDIUM_FLOAT, true, "b", kVarVarying }
   };
@@ skipping 188 matching lines @@
   ProgramManagerWithCacheTest()
       : cache_(new MockProgramCache()),
         vertex_shader_(NULL),
         fragment_shader_(NULL),
         program_(NULL) {
   }
 
  protected:
   void SetupProgramManager() override {
     manager_.reset(new ProgramManager(cache_.get(), kMaxVaryingVectors,
+                                      kMaxDrawBuffers,
                                       kMaxDualSourceDrawBuffers,
                                       gpu_preferences_,
                                       feature_info_.get()));
   }
 
   void SetUp() override {
     ProgramManagerTestBase::SetUp();
 
     vertex_shader_ = shader_manager_.CreateShader(
        kVertexShaderClientId, kVertexShaderServiceId, GL_VERTEX_SHADER);
@@ skipping 434 matching lines @@
     ProgramManagerDualSourceBlendingES2Test,
     testing::Values(
         make_gl_ext_tuple("3.2",
                           "GL_ARB_draw_buffers GL_ARB_blend_func_extended "
                           "GL_ARB_program_interface_query"),
         make_gl_ext_tuple("opengl es 3.1",
                           "GL_EXT_draw_buffers GL_EXT_blend_func_extended")));
 
 }  // namespace gles2
 }  // namespace gpu