Validate fbo color image format and fragment shader output variable type.

gpu/command_buffer/service/framebuffer_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/framebuffer_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/logging.h"
@@ skipping 359 matching lines @@
     : manager_(manager),
       deleted_(false),
       service_id_(service_id),
       has_been_bound_(false),
       framebuffer_complete_state_count_id_(0),
       read_buffer_(GL_COLOR_ATTACHMENT0) {
   manager->StartTracking(this);
   DCHECK_GT(manager->max_draw_buffers_, 0u);
   draw_buffers_.reset(new GLenum[manager->max_draw_buffers_]);
   draw_buffers_[0] = GL_COLOR_ATTACHMENT0;
-  for (uint32_t i = 1; i < manager->max_draw_buffers_; ++i)
-    draw_buffers_[i] = GL_NONE;
+  for (uint32_t ii = 1; ii < manager->max_draw_buffers_; ++ii) {
+    draw_buffers_[ii] = GL_NONE;
+  }
+
+  color_attachment_base_types_.resize(manager->max_draw_buffers_);
+  ResetColorAttachmentBaseTypes();
 }
 
 Framebuffer::~Framebuffer() {
   if (manager_) {
     if (manager_->have_context_) {
       GLuint id = service_id();
       glDeleteFramebuffersEXT(1, &id);
     }
     manager_->StopTracking(this);
     manager_ = NULL;
   }
 }
 
+void Framebuffer::ResetColorAttachmentBaseTypes() {
+  for (size_t ii = 1; ii < color_attachment_base_types_.size(); ++ii) {
+    color_attachment_base_types_[ii] = SHADER_VARIABLE_UNDEFINED_TYPE;
+  }
+}
+
 bool Framebuffer::HasUnclearedAttachment(
     GLenum attachment) const {
   AttachmentMap::const_iterator it =
       attachments_.find(attachment);
   if (it != attachments_.end()) {
     const Attachment* attachment = it->second.get();
     return !attachment->cleared();
   }
   return false;
 }
@@ skipping 88 matching lines @@
     if (buffers[i] != draw_buffers_[i]) {
       different = true;
       break;
     }
   }
   if (different)
     glDrawBuffersARB(manager_->max_draw_buffers_, buffers.get());
   return different;
 }
 
-void Framebuffer::RestoreDrawBuffersAfterClear() const {
+void Framebuffer::RestoreDrawBuffers() const {
   glDrawBuffersARB(manager_->max_draw_buffers_, draw_buffers_.get());
 }
 
 void Framebuffer::ClearUnclearedIntOr3DTexturesOrPartiallyClearedTextures(
     GLES2Decoder* decoder,
     TextureManager* texture_manager) {
   for (AttachmentMap::const_iterator it = attachments_.begin();
        it != attachments_.end(); ++it) {
     if (!it->second->IsTextureAttachment() || it->second->cleared())
       continue;
@@ skipping 297 matching lines @@
         // TODO(gman): manually detach texture.
         // glFramebufferTexture2DEXT(target, it->first, GL_TEXTURE_2D, 0, 0);
         AttachTexture(it->first, NULL, GL_TEXTURE_2D, 0, 0);
         done = false;
         break;
       }
     }
   } while (!done);
 }
 
+void Framebuffer::UpdateColorAttachmentBaseTypes() {
+  ResetColorAttachmentBaseTypes();
+  for (AttachmentMap::const_iterator it = attachments_.begin();
+       it != attachments_.end(); ++it) {
+    if (it->first < GL_COLOR_ATTACHMENT0 ||
+        it->first >= GL_COLOR_ATTACHMENT0 + manager_->max_draw_buffers_) {
+      continue;
+    }
+    size_t index = it->first - GL_COLOR_ATTACHMENT0;
+    Attachment* attachment = it->second.get();
+    GLenum internal_format = attachment->internal_format();
+    if (GLES2Util::IsSignedIntegerFormat(internal_format)) {
+      color_attachment_base_types_[index] = SHADER_VARIABLE_INT;
+    } else if (GLES2Util::IsUnsignedIntegerFormat(internal_format)) {
+      color_attachment_base_types_[index] = SHADER_VARIABLE_UINT;
+    } else {
+      color_attachment_base_types_[index] = SHADER_VARIABLE_FLOAT;
+    }
+  }
+}
+
 Framebuffer* FramebufferManager::GetFramebuffer(
     GLuint client_id) {
   FramebufferMap::iterator it = framebuffers_.find(client_id);
   return it != framebuffers_.end() ? it->second.get() : NULL;
 }
 
 void FramebufferManager::RemoveFramebuffer(GLuint client_id) {
   FramebufferMap::iterator it = framebuffers_.find(client_id);
   if (it != framebuffers_.end()) {
     it->second->MarkAsDeleted();
@@ skipping 103 matching lines @@
 
 bool FramebufferManager::IsComplete(
     Framebuffer* framebuffer) {
   DCHECK(framebuffer);
   return framebuffer->framebuffer_complete_state_count_id() ==
       framebuffer_state_change_count_;
 }
 
 }  // namespace gles2
 }  // namespace gpu