Validate fbo color image format and fragment shader output variable type.

gpu/command_buffer/service/context_state.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/context_state.h"
 
 #include <stddef.h>
 
 #include <cmath>
 
@@ skipping 80 matching lines @@
 
 TextureUnit::TextureUnit(const TextureUnit& other) = default;
 
 TextureUnit::~TextureUnit() {
 }
 
 bool Vec4::Equal(const Vec4& other) const {
   if (type_ != other.type_)
     return false;
   switch (type_) {
-    case kFloat:
+    case SHADER_VARIABLE_FLOAT:
       for (size_t ii = 0; ii < 4; ++ii) {
         if (v_[ii].float_value != other.v_[ii].float_value)
           return false;
       }
       break;
-    case kInt:
+    case SHADER_VARIABLE_INT:
       for (size_t ii = 0; ii < 4; ++ii) {
         if (v_[ii].int_value != other.v_[ii].int_value)
           return false;
       }
       break;
-    case kUInt:
+    case SHADER_VARIABLE_UINT:
       for (size_t ii = 0; ii < 4; ++ii) {
         if (v_[ii].uint_value != other.v_[ii].uint_value)
           return false;
       }
       break;
+    default:
+      NOTREACHED();
+      break;
   }
   return true;
 }
 
 template <>
 void Vec4::GetValues<GLfloat>(GLfloat* values) const {
   DCHECK(values);
   switch (type_) {
-    case kFloat:
+    case SHADER_VARIABLE_FLOAT:
       for (size_t ii = 0; ii < 4; ++ii)
         values[ii] = v_[ii].float_value;
       break;
-    case kInt:
+    case SHADER_VARIABLE_INT:
       for (size_t ii = 0; ii < 4; ++ii)
         values[ii] = static_cast<GLfloat>(v_[ii].int_value);
       break;
-    case kUInt:
+    case SHADER_VARIABLE_UINT:
       for (size_t ii = 0; ii < 4; ++ii)
         values[ii] = static_cast<GLfloat>(v_[ii].uint_value);
       break;
+    default:
+      NOTREACHED();
+      break;
   }
 }
 
 template <>
 void Vec4::GetValues<GLint>(GLint* values) const {
   DCHECK(values);
   switch (type_) {
-    case kFloat:
+    case SHADER_VARIABLE_FLOAT:
       for (size_t ii = 0; ii < 4; ++ii)
         values[ii] = static_cast<GLint>(v_[ii].float_value);
       break;
-    case kInt:
+    case SHADER_VARIABLE_INT:
       for (size_t ii = 0; ii < 4; ++ii)
         values[ii] = v_[ii].int_value;
       break;
-    case kUInt:
+    case SHADER_VARIABLE_UINT:
       for (size_t ii = 0; ii < 4; ++ii)
         values[ii] = static_cast<GLint>(v_[ii].uint_value);
       break;
+    default:
+      NOTREACHED();
+      break;
   }
 }
 
 template<>
 void Vec4::GetValues<GLuint>(GLuint* values) const {
   DCHECK(values);
   switch (type_) {
-    case kFloat:
+    case SHADER_VARIABLE_FLOAT:
       for (size_t ii = 0; ii < 4; ++ii)
         values[ii] = static_cast<GLuint>(v_[ii].float_value);
       break;
-    case kInt:
+    case SHADER_VARIABLE_INT:
       for (size_t ii = 0; ii < 4; ++ii)
         values[ii] = static_cast<GLuint>(v_[ii].int_value);
       break;
-    case kUInt:
+    case SHADER_VARIABLE_UINT:
       for (size_t ii = 0; ii < 4; ++ii)
         values[ii] = v_[ii].uint_value;
       break;
+    default:
+      NOTREACHED();
+      break;
   }
 }
 
 template <>
 void Vec4::SetValues<GLfloat>(const GLfloat* values) {
   DCHECK(values);
   for (size_t ii = 0; ii < 4; ++ii)
     v_[ii].float_value = values[ii];
-  type_ = kFloat;
+  type_ = SHADER_VARIABLE_FLOAT;
 }
 
 template <>
 void Vec4::SetValues<GLint>(const GLint* values) {
   DCHECK(values);
   for (size_t ii = 0; ii < 4; ++ii)
     v_[ii].int_value = values[ii];
-  type_ = kInt;
+  type_ = SHADER_VARIABLE_INT;
 }
 
 template <>
 void Vec4::SetValues<GLuint>(const GLuint* values) {
   DCHECK(values);
   for (size_t ii = 0; ii < 4; ++ii)
     v_[ii].uint_value = values[ii];
-  type_ = kUInt;
+  type_ = SHADER_VARIABLE_UINT;
 }
 
 ContextState::ContextState(FeatureInfo* feature_info,
                            ErrorStateClient* error_state_client,
                            Logger* logger)
     : active_texture_unit(0),
       bound_renderbuffer_valid(false),
       pack_reverse_row_order(false),
       ignore_cached_state(false),
       fbo_binding_for_scissor_workaround_dirty(false),
@@ skipping 129 matching lines @@
   DCHECK_LT(active_texture_unit, texture_units.size());
   const TextureUnit& texture_unit = texture_units[active_texture_unit];
   if (TargetIsSupported(feature_info_, target))
     glBindTexture(target, GetServiceId(texture_unit, target));
 }
 
 void ContextState::RestoreVertexAttribValues() const {
   for (size_t attrib = 0; attrib < vertex_attrib_manager->num_attribs();
        ++attrib) {
     switch (attrib_values[attrib].type()) {
-      case Vec4::kFloat:
+      case SHADER_VARIABLE_FLOAT:
         {
           GLfloat v[4];
           attrib_values[attrib].GetValues(v);
           glVertexAttrib4fv(attrib, v);
         }
         break;
-      case Vec4::kInt:
+      case SHADER_VARIABLE_INT:
         {
           GLint v[4];
           attrib_values[attrib].GetValues(v);
           glVertexAttribI4iv(attrib, v);
         }
         break;
-      case Vec4::kUInt:
+      case SHADER_VARIABLE_UINT:
         {
           GLuint v[4];
           attrib_values[attrib].GetValues(v);
           glVertexAttribI4uiv(attrib, v);
         }
         break;
+      default:
+        NOTREACHED();
+        break;
     }
   }
 }
 
 void ContextState::RestoreVertexAttribArrays(
     const scoped_refptr<VertexAttribManager> attrib_manager) const {
   // This is expected to be called only for VAO with service_id 0,
   // either to restore the default VAO or a virtual VAO with service_id 0.
   GLuint vao_service_id = attrib_manager->service_id();
   DCHECK(vao_service_id == 0);
@@ skipping 285 matching lines @@
   UpdateUnpackParameters();
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "gpu/command_buffer/service/context_state_impl_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu