Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214233005: Move mock_quota_manager and friends from webkit/ to content/ (Closed)

Created:
6 years, 8 months ago by pilgrim_google
Modified:
6 years, 8 months ago
CC:
chromium-reviews, michaeln, tzik, alecflett, jam, nhiroki, darin-cc_chromium.org, ericu+idb_chromium.org, cmumford, dgrogan, kinuko+watch, jsbell+idb_chromium.org
Visibility:
Public.

Description

Move mock_quota_manager and friends from webkit/ to content/ BUG=338338 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262569

Patch Set 1 #

Patch Set 2 : still not working #

Patch Set 3 : rebase #

Patch Set 4 : use FORWARD_DECLARE_TEST to fix compile errors #

Total comments: 1

Patch Set 5 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -889 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
A + content/browser/appcache/appcache_storage_unittest.cc View 1 2 3 3 chunks +12 lines, -5 lines 0 comments Download
M content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/fileapi/file_system_context_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 1 2 3 4 chunks +8 lines, -8 lines 0 comments Download
M content/browser/fileapi/file_system_operation_impl_write_unittest.cc View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_quota_client_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/quota/mock_quota_manager.h View 3 chunks +12 lines, -4 lines 0 comments Download
A + content/browser/quota/mock_quota_manager.cc View 3 chunks +5 lines, -3 lines 0 comments Download
A + content/browser/quota/mock_quota_manager_proxy.h View 1 2 3 2 chunks +8 lines, -6 lines 0 comments Download
A + content/browser/quota/mock_quota_manager_proxy.cc View 2 chunks +5 lines, -3 lines 0 comments Download
A + content/browser/quota/mock_quota_manager_unittest.cc View 1 2 3 3 chunks +9 lines, -4 lines 0 comments Download
M content/browser/storage_partition_impl_unittest.cc View 1 2 3 8 chunks +8 lines, -8 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M webkit/browser/appcache/appcache_storage.h View 1 2 3 3 chunks +9 lines, -3 lines 0 comments Download
D webkit/browser/appcache/appcache_storage_unittest.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D webkit/browser/quota/mock_quota_manager.h View 1 chunk +0 lines, -144 lines 0 comments Download
D webkit/browser/quota/mock_quota_manager.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D webkit/browser/quota/mock_quota_manager_proxy.h View 1 chunk +0 lines, -85 lines 0 comments Download
D webkit/browser/quota/mock_quota_manager_proxy.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D webkit/browser/quota/mock_quota_manager_unittest.cc View 1 chunk +0 lines, -222 lines 0 comments Download
M webkit/browser/quota/quota_manager.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
pilgrim_google
6 years, 8 months ago (2014-04-08 15:19:44 UTC) #1
jam
lgtm with comment https://codereview.chromium.org/214233005/diff/60001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/214233005/diff/60001/chrome/chrome_tests_unit.gypi#newcode288 chrome/chrome_tests_unit.gypi:288: '../content/browser/quota/mock_quota_manager_proxy.h', chrome can only include files ...
6 years, 8 months ago (2014-04-08 16:14:00 UTC) #2
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 8 months ago (2014-04-08 17:50:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/214233005/40002
6 years, 8 months ago (2014-04-08 17:50:16 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-08 18:30:16 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60165
6 years, 8 months ago (2014-04-08 18:30:16 UTC) #6
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 8 months ago (2014-04-08 20:50:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/214233005/40002
6 years, 8 months ago (2014-04-08 20:50:54 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-08 20:51:46 UTC) #9
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
6 years, 8 months ago (2014-04-08 20:51:46 UTC) #10
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 8 months ago (2014-04-08 21:15:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/214233005/40002
6 years, 8 months ago (2014-04-08 21:16:32 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 00:21:46 UTC) #13
Message was sent while issue was closed. 
Change committed as 262569

Powered by Google App Engine
This is Rietveld 408576698