Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2408)

Unified Diff: telemetry/telemetry/value/__init__.py

Issue 2142293002: [Telemetry] Also merge across tir_labels for TBM (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Fix failing tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/internal/results/output_formatter.py ('k') | telemetry/telemetry/value/histogram.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/value/__init__.py
diff --git a/telemetry/telemetry/value/__init__.py b/telemetry/telemetry/value/__init__.py
index eb58f6222effc1fdd3cbc6640e7caa990bf07b17..5b4ad1d0aa1c97f2775cc5658f1bb8b11acb4d15 100644
--- a/telemetry/telemetry/value/__init__.py
+++ b/telemetry/telemetry/value/__init__.py
@@ -312,6 +312,32 @@ class Value(object):
return d
+
+def MergedTirLabel(values):
+ """Returns the tir_label that should be applied to a merge of values.
+
+ As of TBMv2, we encounter situations where we need to merge values with
+ different tir_labels because Telemetry's tir_label field is being used to
+ store story keys for system health stories. As such, when merging, we want to
+ take the common tir_label if all values share the same label (legacy
+ behavior), or have no tir_label if not.
+
+ Args:
+ values: a list of Value instances
+
+ Returns:
+ The tir_label that would be set on the merge of |values|.
+ """
+ assert len(values) > 0
+ v0 = values[0]
+
+ first_tir_label = v0.tir_label
+ if all(v.tir_label == first_tir_label for v in values):
+ return first_tir_label
+ else:
+ return None
+
+
def ValueNameFromTraceAndChartName(trace_name, chart_name=None):
"""Mangles a trace name plus optional chart name into a standard string.
@@ -330,6 +356,7 @@ def ValueNameFromTraceAndChartName(trace_name, chart_name=None):
'empty chart_name since this is used to delimit chart_name.trace_name.')
return trace_name
+
def _ConvertValueNameToChartAndTraceName(value_name):
"""Converts a value_name into the equivalent chart-trace name pair.
« no previous file with comments | « telemetry/telemetry/internal/results/output_formatter.py ('k') | telemetry/telemetry/value/histogram.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698