Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: test/unittests/interpreter/interpreter-assembler-unittest.cc

Issue 2142273003: [interpreter] Inline Star on dispatch for some bytecodes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: restrict InterpreterAssemblerTest.Jump to jumps Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/interpreter-assembler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/interpreter/interpreter-assembler-unittest.cc
diff --git a/test/unittests/interpreter/interpreter-assembler-unittest.cc b/test/unittests/interpreter/interpreter-assembler-unittest.cc
index 1bc80c0e4a7eeb635cd881c1a87eb9fdfdb77bfa..c1be2eba763d3ae5d56e17f428bee7136a3bf1e6 100644
--- a/test/unittests/interpreter/interpreter-assembler-unittest.cc
+++ b/test/unittests/interpreter/interpreter-assembler-unittest.cc
@@ -332,6 +332,32 @@ TARGET_TEST_F(InterpreterAssemblerTest, Dispatch) {
IsParameter(InterpreterDispatchDescriptor::kDispatchTableParameter),
IsWordShl(target_bytecode_matcher, IsIntPtrConstant(kPointerSizeLog2)));
+ if (interpreter::Bytecodes::IsStarLookahead(bytecode, operand_scale)) {
+ Matcher<Node*> after_lookahead_offset =
+ IsIntPtrAdd(next_bytecode_offset_matcher,
+ IsIntPtrConstant(interpreter::Bytecodes::Size(
+ Bytecode::kStar, operand_scale)));
+ next_bytecode_offset_matcher =
+ IsPhi(MachineType::PointerRepresentation(),
+ next_bytecode_offset_matcher, after_lookahead_offset, _);
+ Matcher<Node*> after_lookahead_bytecode = m.IsLoad(
+ MachineType::Uint8(),
+ IsParameter(InterpreterDispatchDescriptor::kBytecodeArrayParameter),
+ after_lookahead_offset);
+ if (kPointerSize == 8) {
+ after_lookahead_bytecode =
+ IsChangeUint32ToUint64(after_lookahead_bytecode);
+ }
+ target_bytecode_matcher =
+ IsPhi(MachineRepresentation::kWord8, target_bytecode_matcher,
+ after_lookahead_bytecode, _);
+ code_target_matcher = m.IsLoad(
+ MachineType::Pointer(),
+ IsParameter(InterpreterDispatchDescriptor::kDispatchTableParameter),
+ IsWordShl(target_bytecode_matcher,
+ IsIntPtrConstant(kPointerSizeLog2)));
+ }
+
EXPECT_THAT(
tail_call_node,
IsTailCall(
@@ -351,6 +377,8 @@ TARGET_TEST_F(InterpreterAssemblerTest, Jump) {
int jump_offsets[] = {-9710, -77, 0, +3, +97109};
TRACED_FOREACH(int, jump_offset, jump_offsets) {
TRACED_FOREACH(interpreter::Bytecode, bytecode, kBytecodes) {
+ if (!interpreter::Bytecodes::IsJump(bytecode)) return;
+
InterpreterAssemblerForTest m(this, bytecode);
Node* tail_call_node = m.Jump(m.IntPtrConstant(jump_offset));
« no previous file with comments | « src/interpreter/interpreter-assembler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698