[interpreter] Inline Star on dispatch for some bytecodes

src/interpreter/interpreter.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/interpreter.h"
 
 #include <fstream>
 
 #include "src/ast/prettyprinter.h"
 #include "src/code-factory.h"
@@ skipping 352 matching lines @@
   Node* reg_index = __ BytecodeOperandReg(0);
   Node* value = __ LoadRegister(reg_index);
   __ SetAccumulator(value);
   __ Dispatch();
 }
 
 // Star <dst>
 //
 // Store accumulator to register <dst>.
 void Interpreter::DoStar(InterpreterAssembler* assembler) {
-  Node* reg_index = __ BytecodeOperandReg(0);
-  Node* accumulator = __ GetAccumulator();
-  __ StoreRegister(accumulator, reg_index);
+  __ StoreAccumulatorToRegister();

[rmcilroy, 2016/07/18 11:07:52]

Not so keen on inlining this into the interpreter-assembler, since it depends on
reading a bytecode operand for a particular bytecode (kStar). Could we either
pass the register index in as a parameter, or just inline the code for both call
sites?

[klaasb, 2016/07/18 15:15:29]

Done. Inlined.

   __ Dispatch();
 }
 
 // Mov <src> <dst>
 //
 // Stores the value of register <src> to register <dst>.
 void Interpreter::DoMov(InterpreterAssembler* assembler) {
   Node* src_index = __ BytecodeOperandReg(0);
   Node* src_value = __ LoadRegister(src_index);
   Node* dst_index = __ BytecodeOperandReg(1);
@@ skipping 1638 matching lines @@
   __ StoreObjectField(generator, JSGeneratorObject::kContinuationOffset,
       __ SmiTag(new_state));
   __ SetAccumulator(old_state);
 
   __ Dispatch();
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8