chrome/browser/android/compositor/layer/contextual_search_layer.h - Issue 2142263002: Remove ContentViewCore dependency from OverlayPanel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/compositor/layer/contextual_search_layer.h

Issue 2142263002: Remove ContentViewCore dependency from OverlayPanel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ReaderModeSceneLayer.java ('k') | chrome/browser/android/compositor/layer/contextual_search_layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/compositor/layer/contextual_search_layer.h

diff --git a/chrome/browser/android/compositor/layer/contextual_search_layer.h b/chrome/browser/android/compositor/layer/contextual_search_layer.h

index 5d28241a6ad4f093894e421cdef9359ed2501e79..846cbc116fed37ac71d8d87cd8536e4c07381bdd 100644

--- a/chrome/browser/android/compositor/layer/contextual_search_layer.h

+++ b/chrome/browser/android/compositor/layer/contextual_search_layer.h

@@ -16,8 +16,8 @@ class SolidColorLayer;

class UIResourceLayer;

}

-namespace content {

-class ContentViewCore;

+namespace cc {

+class Layer;

}

namespace ui {

@@ -49,7 +49,7 @@ class ContextualSearchLayer : public OverlayPanelLayer {

int peek_promo_ripple_resource_id,

int peek_promo_text_resource_id,

float dp_to_px,

- content::ContentViewCore* content_view_core,

+ scoped_refptr<cc::Layer> content_layer,

no sievers 2016/07/12 23:44:16 nit: scoped_refptr const-ref here and elsewhere

mdjones 2016/07/13 00:21:31 Done.

bool search_promo_visible,

float search_promo_height,

float search_promo_opacity,