Add support for new iossim in Xcode 8.

scripts/slave/ios/test_runner.py

 #!/usr/bin/python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Contains test runners for launching tests on simulators and devices."""
 
 # pylint: disable=relative-import
 import environment_setup
 
@@ skipping 469 matching lines @@
       '-c', 'Print:CFBundleIdentifier',
       os.path.join(self.app_path, 'Info.plist'),
     ).stdout[0]
 
     self.iossim_path = iossim_path
     self.platform = platform
     self.version = version
     self.timeout = '120'
     self.homedir = ''
     self.start_time = None
+    self.xcode_version = xcode_version

[smut, 2016/07/12 23:58:59]

Can probably set this in the base class.

[justincohen, 2016/07/14 19:59:50]

Done.

 
   def SetStartTime(self):
     """Sets the start time, for finding crash reports during this run."""
     # Crash reports have a timestamp in their filename, formatted as
     # YYYY-MM-DD-HHMMSS.
     self.start_time = time.strftime('%Y-%m-%d-%H%M%S', time.localtime())
 
   def CreateNewHomeDirectory(self):
     """Creates a new home directory for the simulator."""
-    self.homedir = tempfile.mkdtemp()
+    if self.xcode_version == '8.0':
+      cmd = [
+        self.iossim_path,
+        '-d', self.platform,
+        '-s', self.version,
+        '-p'
+      ]

[smut, 2016/07/12 23:58:59]

Can we use -w to wipe the simulator here, so that every time
CreateNewHomeDirectory is called we are getting a fresh simulator with a
different homedir?

[justincohen, 2016/07/14 19:59:50]

See below.

[smut, 2016/07/14 21:25:54]

I think it should wipe here as well. This call that needs to ensure we get a new
home directory. e.g. if CreateNewHomeDirectory is called twice in a row for
Xcode 7 it will actually get a new home dir the second time, but for Xcode 8 it
seems like it would just print the same thing out unless it was explicitly
wiped. Am I wrong about that?

[justincohen, 2016/07/14 22:24:32]

Wipe is very fast, this SGTM, done.

+      self.homedir = subprocess.check_output(cmd)
+    else:
+      self.homedir = tempfile.mkdtemp()
+
 
   def RemoveHomeDirectory(self):
     """Recursively removes the home directory being used by the simulator."""
-    if os.path.exists(self.homedir):
-      shutil.rmtree(self.homedir, ignore_errors=True)
+    if self.xcode_version == '8.0':
       self.homedir = ''

[smut, 2016/07/12 23:58:59]

I think it should shutil.rmtree even on Xcode 8 so we do the post-test cleanup
and free up the disk space used to install and run the test.

[justincohen, 2016/07/14 19:59:50]

Xcode seems to freak out.  How about we just call -w here instead?

[smut, 2016/07/14 21:25:54]

Ok seems fine. -w should wipe the installed app and any data it wrote to the
simulator and free up the disk space anyways, right?

[justincohen, 2016/07/14 22:24:32]

yes/

+    else:
+      if os.path.exists(self.homedir):
+        shutil.rmtree(self.homedir, ignore_errors=True)
+        self.homedir = ''
 
   def KillSimulators(self):
     """Forcibly kills any running iOS simulator instances."""
     kill_cmd = [
       'pkill',
       '-9',
       '-x',
       # The iOS simulator has a different name depending on the Xcode version.
       'iPhone Simulator',  # Xcode 5
       'iOS Simulator',  # Xcode 6
@@ skipping 159 matching lines @@
       blacklist: Whether to blacklist the elements of test_filter or not. Only
         works when test_filter is not None.
 
     Returns:
       A list whose elements are the args representing the command.
     """
     cmd = [
       self.iossim_path,
       '-d', self.platform,
       '-s', self.version,
-      '-t', self.timeout,
-      '-u', self.homedir,
     ]
+
     args = []
 
+    if self.xcode_version == '8.0':
+      cmd.extend(['-w'])

[smut, 2016/07/12 23:58:59]

I don't think it should include -w here. GetLaunchCommand may be called multiple
times to ensure all the test cases run even if one crashes and these should all
be in the same simulator so we can get all the test data at the end. Won't -w
erase the test data in the test's Documents directory when it wipes the
simulator?

[justincohen, 2016/07/14 19:59:50]

Removed.

+    else:
+      cmd.extend([
+        '-t', self.timeout,
+        '-u', self.homedir
+      ])
+
     if test_filter is not None:
       kif_filter = self.GetKIFTestFilter(test_filter, blacklist)
       gtest_filter = self.GetGTestFilter(test_filter, blacklist)
 
       cmd.extend([
        '-e', 'GKIF_SCENARIO_FILTER=%s' % kif_filter,
       ])
-      args.append('--gtest_filter=%s' % gtest_filter)
+
+      if self.xcode_version == '8.0':
+        cmd.extend([
+         '-c', '--gtest_filter=%s' % gtest_filter,
+        ])
+      else:
+        args.append('--gtest_filter=%s' % gtest_filter)
 
     cmd.append(self.app_path)
     cmd.extend(self.test_args)
     cmd.extend(args)
     return cmd
 
   @TestRunner.RequireTearDown
   def Launch(self, *args, **kwargs):
     """Launches the test."""
     self.SetUp()
@@ skipping 681 matching lines @@
       )
 
       # Uninstall and re-install the app.
       self.UninstallApp()
       self.InstallApp()
 
       result = self._Run(
         self.GetLaunchCommand(), self.GetLaunchEnvironment(), *args, **kwargs)
 
     return self.RunAllTests(result, *args, **kwargs)