Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: src/parsing/parser.cc

Issue 2142233003: Templatize AstVisitor with its subclass (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/parser.h ('k') | src/parsing/parser-base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parser.cc
diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc
index 62a6ff5df41d07c9013c6093867d21fc214d0d2a..5e4206e206e283eff7f31a8451229f58e7353eca 100644
--- a/src/parsing/parser.cc
+++ b/src/parsing/parser.cc
@@ -634,10 +634,9 @@ Expression* ParserTraits::ThisExpression(Scope* scope, AstNodeFactory* factory,
Variable::THIS, pos, pos + 4);
}
-
-Expression* ParserTraits::SuperPropertyReference(Scope* scope,
- AstNodeFactory* factory,
- int pos) {
+Expression* ParserTraits::NewSuperPropertyReference(Scope* scope,
+ AstNodeFactory* factory,
+ int pos) {
// this_function[home_object_symbol]
VariableProxy* this_function_proxy = scope->NewUnresolved(
factory, parser_->ast_value_factory()->this_function_string(),
@@ -650,9 +649,9 @@ Expression* ParserTraits::SuperPropertyReference(Scope* scope,
ThisExpression(scope, factory, pos)->AsVariableProxy(), home_object, pos);
}
-
-Expression* ParserTraits::SuperCallReference(Scope* scope,
- AstNodeFactory* factory, int pos) {
+Expression* ParserTraits::NewSuperCallReference(Scope* scope,
+ AstNodeFactory* factory,
+ int pos) {
VariableProxy* new_target_proxy = scope->NewUnresolved(
factory, parser_->ast_value_factory()->new_target_string(),
Variable::NORMAL, pos);
« no previous file with comments | « src/parsing/parser.h ('k') | src/parsing/parser-base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698