src/full-codegen/full-codegen.cc - Issue 2142233003: Templatize AstVisitor with its subclass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 2142233003: Templatize AstVisitor with its subclass (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index 79c887ade32c2e43029cb3a17d64d37f2d7b5b6f..8f7684dfa752c9db9e8777133ddd68300c24599c 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -390,7 +390,7 @@ void FullCodeGenerator::VisitDeclarations(

ZoneList<Handle<Object> > inner_globals(10, zone());

globals_ = &inner_globals;

- AstVisitor::VisitDeclarations(declarations);

+ AstVisitor<FullCodeGenerator>::VisitDeclarations(declarations);

if (!globals_->is_empty()) {

// Invoke the platform-dependent code generator to do the actual

« no previous file with comments | « src/full-codegen/full-codegen.h ('k') | src/interpreter/bytecode-generator.h » ('j') | no next file with comments »