Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: src/ast/ast-numbering.cc

Issue 2142233003: Templatize AstVisitor with its subclass (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast-literal-reindexer.cc ('k') | src/ast/prettyprinter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast-numbering.cc
diff --git a/src/ast/ast-numbering.cc b/src/ast/ast-numbering.cc
index e2ee8657976518ede891e3cd126108d1f223a214..0fd88312c3e40acad30812ad5c6e4c1503391de6 100644
--- a/src/ast/ast-numbering.cc
+++ b/src/ast/ast-numbering.cc
@@ -10,11 +10,10 @@
namespace v8 {
namespace internal {
-class AstNumberingVisitor final : public AstVisitor {
+class AstNumberingVisitor final : public AstVisitor<AstNumberingVisitor> {
public:
AstNumberingVisitor(Isolate* isolate, Zone* zone)
- : AstVisitor(),
- isolate_(isolate),
+ : isolate_(isolate),
zone_(zone),
next_id_(BailoutId::FirstUsable().ToInt()),
yield_count_(0),
@@ -29,7 +28,7 @@ class AstNumberingVisitor final : public AstVisitor {
private:
// AST node visitor interface.
-#define DEFINE_VISIT(type) void Visit##type(type* node) override;
+#define DEFINE_VISIT(type) void Visit##type(type* node);
AST_NODE_LIST(DEFINE_VISIT)
#undef DEFINE_VISIT
@@ -37,8 +36,8 @@ class AstNumberingVisitor final : public AstVisitor {
void VisitPropertyReference(Property* node);
void VisitReference(Expression* expr);
- void VisitStatements(ZoneList<Statement*>* statements) override;
- void VisitDeclarations(ZoneList<Declaration*>* declarations) override;
+ void VisitStatements(ZoneList<Statement*>* statements);
+ void VisitDeclarations(ZoneList<Declaration*>* declarations);
void VisitArguments(ZoneList<Expression*>* arguments);
void VisitObjectLiteralProperty(ObjectLiteralProperty* property);
« no previous file with comments | « src/ast/ast-literal-reindexer.cc ('k') | src/ast/prettyprinter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698