src/crankshaft/hydrogen.cc - Issue 2142233003: Templatize AstVisitor with its subclass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2142233003: Templatize AstVisitor with its subclass (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index 2f6ebcd6293a35f490ed726bd58411102fcc80aa..3cacbafe456bb2417dbcd2b8b22937f4c90dcc48 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -12133,7 +12133,7 @@ void HOptimizedGraphBuilder::VisitSuperCallReference(SuperCallReference* expr) {

void HOptimizedGraphBuilder::VisitDeclarations(

ZoneList<Declaration*>* declarations) {

DCHECK(globals_.is_empty());

- AstVisitor::VisitDeclarations(declarations);

+ AstVisitor<HOptimizedGraphBuilder>::VisitDeclarations(declarations);

if (!globals_.is_empty()) {

Handle<FixedArray> array =

isolate()->factory()->NewFixedArray(globals_.length(), TENURED);