Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 2142233003: Templatize AstVisitor with its subclass (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index 1f28db16e01641951b95c6f7a68f67b7956cf30b..cdb408beeda850a0eeec22fb97e919c14c285ac5 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -1072,7 +1072,7 @@ void AstGraphBuilder::VisitForValues(ZoneList<Expression*>* exprs) {
void AstGraphBuilder::VisitForValue(Expression* expr) {
AstValueContext for_value(this);
if (!CheckStackOverflow()) {
- expr->Accept(this);
+ AstVisitor<AstGraphBuilder>::Visit(expr);
} else {
ast_context()->ProduceValue(expr, jsgraph()->UndefinedConstant());
}
@@ -1082,7 +1082,7 @@ void AstGraphBuilder::VisitForValue(Expression* expr) {
void AstGraphBuilder::VisitForEffect(Expression* expr) {
AstEffectContext for_effect(this);
if (!CheckStackOverflow()) {
- expr->Accept(this);
+ AstVisitor<AstGraphBuilder>::Visit(expr);
} else {
ast_context()->ProduceValue(expr, jsgraph()->UndefinedConstant());
}
@@ -1092,7 +1092,7 @@ void AstGraphBuilder::VisitForEffect(Expression* expr) {
void AstGraphBuilder::VisitForTest(Expression* expr) {
AstTestContext for_condition(this, expr->test_id());
if (!CheckStackOverflow()) {
- expr->Accept(this);
+ AstVisitor<AstGraphBuilder>::Visit(expr);
} else {
ast_context()->ProduceValue(expr, jsgraph()->UndefinedConstant());
}
@@ -1102,7 +1102,7 @@ void AstGraphBuilder::VisitForTest(Expression* expr) {
void AstGraphBuilder::Visit(Expression* expr) {
// Reuses enclosing AstContext.
if (!CheckStackOverflow()) {
- expr->Accept(this);
+ AstVisitor<AstGraphBuilder>::Visit(expr);
} else {
ast_context()->ProduceValue(expr, jsgraph()->UndefinedConstant());
}
@@ -2938,7 +2938,7 @@ void AstGraphBuilder::VisitCaseClause(CaseClause* expr) {
void AstGraphBuilder::VisitDeclarations(ZoneList<Declaration*>* declarations) {
DCHECK(globals()->empty());
- AstVisitor::VisitDeclarations(declarations);
+ AstVisitor<AstGraphBuilder>::VisitDeclarations(declarations);
if (globals()->empty()) return;
int array_index = 0;
Handle<FixedArray> data = isolate()->factory()->NewFixedArray(

Powered by Google App Engine
This is Rietveld 408576698