Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: src/ast/ast-expression-rewriter.h

Issue 2142233003: Templatize AstVisitor with its subclass (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast/ast.cc ('k') | src/ast/ast-literal-reindexer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_AST_AST_EXPRESSION_REWRITER_H_ 5 #ifndef V8_AST_AST_EXPRESSION_REWRITER_H_
6 #define V8_AST_AST_EXPRESSION_REWRITER_H_ 6 #define V8_AST_AST_EXPRESSION_REWRITER_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/ast/ast.h" 9 #include "src/ast/ast.h"
10 #include "src/ast/scopes.h" 10 #include "src/ast/scopes.h"
11 #include "src/type-info.h" 11 #include "src/type-info.h"
12 #include "src/zone.h" 12 #include "src/zone.h"
13 13
14 namespace v8 { 14 namespace v8 {
15 namespace internal { 15 namespace internal {
16 16
17 // A rewriting Visitor over a CompilationInfo's AST that invokes 17 // A rewriting Visitor over a CompilationInfo's AST that invokes
18 // VisitExpression on each expression node. 18 // VisitExpression on each expression node.
19 19
20 class AstExpressionRewriter : public AstVisitor { 20 // This AstVistor is not final, and provides the AstVisitor methods as virtual
21 // methods so they can be specialized by subclasses.
22 class AstExpressionRewriter : public AstVisitor<AstExpressionRewriter> {
21 public: 23 public:
22 explicit AstExpressionRewriter(Isolate* isolate) : AstVisitor() { 24 explicit AstExpressionRewriter(Isolate* isolate) {
23 InitializeAstRewriter(isolate); 25 InitializeAstRewriter(isolate);
24 } 26 }
25 explicit AstExpressionRewriter(uintptr_t stack_limit) : AstVisitor() { 27 explicit AstExpressionRewriter(uintptr_t stack_limit) {
26 InitializeAstRewriter(stack_limit); 28 InitializeAstRewriter(stack_limit);
27 } 29 }
28 ~AstExpressionRewriter() override {} 30 virtual ~AstExpressionRewriter() {}
29 31
30 void VisitDeclarations(ZoneList<Declaration*>* declarations) override; 32 virtual void VisitDeclarations(ZoneList<Declaration*>* declarations);
31 void VisitStatements(ZoneList<Statement*>* statements) override; 33 virtual void VisitStatements(ZoneList<Statement*>* statements);
32 void VisitExpressions(ZoneList<Expression*>* expressions) override; 34 virtual void VisitExpressions(ZoneList<Expression*>* expressions);
33 35
34 virtual void VisitObjectLiteralProperty(ObjectLiteralProperty* property); 36 virtual void VisitObjectLiteralProperty(ObjectLiteralProperty* property);
35 37
36 protected: 38 protected:
37 virtual bool RewriteExpression(Expression* expr) = 0; 39 virtual bool RewriteExpression(Expression* expr) = 0;
38 40
39 private: 41 private:
40 DEFINE_AST_REWRITER_SUBCLASS_MEMBERS(); 42 DEFINE_AST_REWRITER_SUBCLASS_MEMBERS();
41 43
42 #define DECLARE_VISIT(type) void Visit##type(type* node) override; 44 #define DECLARE_VISIT(type) virtual void Visit##type(type* node);
43 AST_NODE_LIST(DECLARE_VISIT) 45 AST_NODE_LIST(DECLARE_VISIT)
44 #undef DECLARE_VISIT 46 #undef DECLARE_VISIT
45 47
46 DISALLOW_COPY_AND_ASSIGN(AstExpressionRewriter); 48 DISALLOW_COPY_AND_ASSIGN(AstExpressionRewriter);
47 }; 49 };
48 50
49 } // namespace internal 51 } // namespace internal
50 } // namespace v8 52 } // namespace v8
51 53
52 #endif // V8_AST_AST_EXPRESSION_REWRITER_H_ 54 #endif // V8_AST_AST_EXPRESSION_REWRITER_H_
OLDNEW
« no previous file with comments | « src/ast/ast.cc ('k') | src/ast/ast-literal-reindexer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698