Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: remoting/host/BUILD.gn

Issue 2142233002: Fix mac remoting GN build failures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/BUILD.gn
diff --git a/remoting/host/BUILD.gn b/remoting/host/BUILD.gn
index e85af02ada4836d5d0b931045d7e897a7dd1ddcd..0100db9504067ef453de5ec03f1df1329aa7ce1d 100644
--- a/remoting/host/BUILD.gn
+++ b/remoting/host/BUILD.gn
@@ -987,6 +987,7 @@ if (enable_me2me_host) {
":credits",
":remoting_me2me_host_static",
"//build/config/sanitizers:deps",
+ "//remoting/base:breakpad",
"//remoting/resources",
]
if (is_mac) {
@@ -1233,44 +1234,45 @@ if (enable_me2me_host) {
root_build_dir)
_extra_files = []
- args = [
- rebase_path("$root_gen_dir/installation", root_build_dir),
- rebase_path(_output, root_build_dir),
- "--source-file-roots",
- rebase_path("//remoting/host/installer/win"),
- "--source-files",
- rebase_path("//remoting/host/installer/win/chromoting.wxs"),
- rebase_path("//remoting/host/installer/win/parameters.json"),
-
- # Input files
- "--generated-files",
- ] + _generated_files +
- [
- rebase_path("//remoting/resources/chromoting.ico"),
-
- # Position of files in zip file
- "--generated-files-dst",
- "files/remote_assistance_host.exe",
- "files/remote_security_key.exe",
- "files/remoting_core.dll",
- "files/remoting_desktop.exe",
- "files/remoting_host.exe",
- "files/remoting_native_messaging_host.exe",
- "files/remoting_start_host.exe",
- "files/CREDITS.txt",
- "files/com.google.chrome.remote_assistance.json",
- "files/com.google.chrome.remote_desktop.json",
- "files/chromoting.ico",
- "files/icudtl.dat",
- ] + _extra_files + # Defs
- [
- "--defs",
- "BRANDING=$_branding",
- "DAEMON_CONTROLLER_CLSID={$daemon_controller_clsid}",
- "RDP_DESKTOP_SESSION_CLSID={$rdp_desktop_session_clsid}",
- "VERSION=$chrome_version_full",
- "OFFICIAL_BUILD=$_official_build",
- ]
+ args =
+ [
+ rebase_path("$root_gen_dir/remoting_installation", root_build_dir),
Dirk Pranke 2016/07/12 20:57:39 The GYP build actually uses SHARED_INTERMEDIATE_DI
+ rebase_path(_output, root_build_dir),
+ "--source-file-roots",
+ rebase_path("//remoting/host/installer/win"),
+ "--source-files",
+ rebase_path("//remoting/host/installer/win/chromoting.wxs"),
+ rebase_path("//remoting/host/installer/win/parameters.json"),
+
+ # Input files
+ "--generated-files",
+ ] + _generated_files +
+ [
+ rebase_path("//remoting/resources/chromoting.ico"),
+
+ # Position of files in zip file
+ "--generated-files-dst",
+ "files/remote_assistance_host.exe",
+ "files/remote_security_key.exe",
+ "files/remoting_core.dll",
+ "files/remoting_desktop.exe",
+ "files/remoting_host.exe",
+ "files/remoting_native_messaging_host.exe",
+ "files/remoting_start_host.exe",
+ "files/CREDITS.txt",
+ "files/com.google.chrome.remote_assistance.json",
+ "files/com.google.chrome.remote_desktop.json",
+ "files/chromoting.ico",
+ "files/icudtl.dat",
+ ] + _extra_files + # Defs
+ [
+ "--defs",
+ "BRANDING=$_branding",
+ "DAEMON_CONTROLLER_CLSID={$daemon_controller_clsid}",
+ "RDP_DESKTOP_SESSION_CLSID={$rdp_desktop_session_clsid}",
+ "VERSION=$chrome_version_full",
+ "OFFICIAL_BUILD=$_official_build",
+ ]
}
} else if (is_mac) {
import("//build/config/zip.gni")
@@ -1311,7 +1313,8 @@ if (enable_me2me_host) {
host_uninstaller_name_nospace = host_uninstaller_name
args = [
- rebase_path(target_gen_dir, root_build_dir),
+ rebase_path("$target_gen_dir/remoting_installation",
+ root_build_dir),
Dirk Pranke 2016/07/12 20:57:39 This uses target_gen_dir instead of root_gen_dir,
rebase_path(zip_path, root_build_dir),
"--source-file-roots",
rebase_path("installer/mac/", root_build_dir),
@@ -1545,7 +1548,7 @@ if (enable_me2me_host) {
"--wix_path",
rebase_path("//third_party/wix"),
"--intermediate_dir",
- rebase_path("$root_gen_dir/installation", root_build_dir),
+ rebase_path("$root_gen_dir/remoting_installation", root_build_dir),
"--target_arch",
msi_script_arch,
rebase_path("$root_out_dir/remoting-me2me-host-$current_os.zip",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698