Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Issue 214223002: In kiosk printing mode, start printing when destination is ready. (Closed)

Created:
6 years, 9 months ago by Aleksey Shlyapnikov
Modified:
6 years, 9 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

In kiosk printing mode, start printing when destination is ready. BUG=339416 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/print_preview/print_preview.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Aleksey Shlyapnikov
6 years, 9 months ago (2014-03-27 03:59:04 UTC) #1
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-27 17:49:35 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 9 months ago (2014-03-27 17:49:41 UTC) #3
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-27 17:49:43 UTC) #4
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-27 17:49:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/214223002/1
6 years, 9 months ago (2014-03-27 17:53:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 20:09:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-27 20:09:39 UTC) #8
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 9 months ago (2014-03-27 21:19:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/214223002/1
6 years, 9 months ago (2014-03-27 21:19:58 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 21:48:52 UTC) #11
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 21:48:53 UTC) #12
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-28 00:12:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/214223002/1
6 years, 9 months ago (2014-03-28 00:16:59 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 00:32:34 UTC) #15
Message was sent while issue was closed.
Change committed as 260041

Powered by Google App Engine
This is Rietveld 408576698