Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/nanobench_flags.py

Issue 2142223004: Turn back on nanobench on Debug trybots. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/nanobench_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/nanobench_flags.py
diff --git a/tools/nanobench_flags.py b/tools/nanobench_flags.py
index 085d30dc62b850670573cbb162302da20ad4b041..12acc0d31745df2167c880d3db0b7f62cb05fd17 100755
--- a/tools/nanobench_flags.py
+++ b/tools/nanobench_flags.py
@@ -134,10 +134,6 @@ def get_args(bot):
match.append('~inc0.webp')
match.append('~inc1.webp')
- # As an experiment, skip nanobench on Debug trybots.
- if 'Debug' in bot and 'CPU' in bot and 'Trybot' in bot:
- match = ['nothing_will_match_this']
-
if match:
args.append('--match')
args.extend(match)
@@ -158,7 +154,6 @@ def self_test():
'Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Debug-ANGLE',
'Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug',
'Test-Android-GCC-GalaxyS4-GPU-SGX544-Arm7-Release',
- 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot',
'Perf-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Release',
'Perf-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Release-Vulkan',
'Perf-Android-GCC-Nexus5-GPU-Adreno330-Arm7-Release',
« no previous file with comments | « tools/nanobench_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698