Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2142223004: Turn back on nanobench on Debug trybots. (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Turn back on nanobench on Debug trybots. Swarming makes the extra wall-clock cost negligible. TBR= BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142223004 Committed: https://skia.googlesource.com/skia/+/6c3ada96ab2326f2119e1e9f44fbc8b0aeadbae8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M tools/nanobench_flags.json View 1 chunk +0 lines, -18 lines 0 comments Download
M tools/nanobench_flags.py View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
mtklein_C
4 years, 5 months ago (2016-07-13 15:59:41 UTC) #3
mtklein_C
This is what we talked about in person. Gonna TBR this while you're out. Hopefully ...
4 years, 5 months ago (2016-07-13 16:01:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142223004/1
4 years, 5 months ago (2016-07-13 16:01:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/9666)
4 years, 5 months ago (2016-07-13 16:15:02 UTC) #9
mtklein_C
We were hoping that bot'd fail... trying again at head.
4 years, 5 months ago (2016-07-13 16:21:18 UTC) #10
borenet
LGTM
4 years, 5 months ago (2016-07-13 16:32:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142223004/1
4 years, 5 months ago (2016-07-13 16:33:43 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 16:44:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6c3ada96ab2326f2119e1e9f44fbc8b0aeadbae8

Powered by Google App Engine
This is Rietveld 408576698