Issue 2142223003: Fix GL shader sources getting truncated by ADB log

Issue 2142223003: Fix GL shader sources getting truncated by ADB log (Closed)

Created:
4 years, 5 months ago by csmartdalton

Modified:
4 years, 5 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Fix GL shader sources getting truncated by ADB log Prints the shaders one line at a time so they don't get truncated by the ADB log. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142223003 Committed: https://skia.googlesource.com/skia/+/b3772dcb306241f53fe10ba62117ed67f89f24b2

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	src/gpu/gl/builders/GrGLShaderStringBuilder.cpp	View		4 chunks	+14 lines, -4 lines	0 comments	Download

Total messages: 9 (4 generated)

csmartdalton

Who would be a good reviewer for this type of change?

4 years, 5 months ago (2016-07-13 04:39:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142223003/1

4 years, 5 months ago (2016-07-13 15:26:26 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b3772dcb306241f53fe10ba62117ed67f89f24b2

4 years, 5 months ago (2016-07-13 15:48:02 UTC) #8

Message was sent while issue was closed.

CQ bit was unchecked.