Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2142173002: Margin tweaks in the desktop user menu UI (Closed)

Created:
4 years, 5 months ago by Jane
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Margin tweaks in the desktop user menu UI Specifically: 1. Horizontal margin tweak in the supervised user disclaimer view 2. Vertical margin tweak in the profile card to center the avatar name / username better See mocks: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#%2Fpreview-2.png See comparative screenshots: https://drive.google.com/a/google.com/folderview?id=0B7Fvv7JszRyGU05yWTRIUVp4OFE&usp=sharing BUG=615893 Committed: https://crrev.com/13628d49e1290169aa763ea3e63ac6c5adb94472 Cr-Commit-Position: refs/heads/master@{#404871}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Modified variable name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jane
PTAL, small change again. Thanks!
4 years, 5 months ago (2016-07-12 18:51:54 UTC) #2
msw
lgtm with a nit. https://codereview.chromium.org/2142173002/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right): https://codereview.chromium.org/2142173002/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc#newcode1804 chrome/browser/ui/views/profiles/profile_chooser_view.cc:1804: int horizontalMargin = switches::IsMaterialDesignUserMenu() ? ...
4 years, 5 months ago (2016-07-12 19:10:00 UTC) #3
Jane
https://codereview.chromium.org/2142173002/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right): https://codereview.chromium.org/2142173002/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc#newcode1804 chrome/browser/ui/views/profiles/profile_chooser_view.cc:1804: int horizontalMargin = switches::IsMaterialDesignUserMenu() ? On 2016/07/12 19:10:00, msw ...
4 years, 5 months ago (2016-07-12 19:15:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142173002/20001
4 years, 5 months ago (2016-07-12 19:17:54 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 01:17:03 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 01:18:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13628d49e1290169aa763ea3e63ac6c5adb94472
Cr-Commit-Position: refs/heads/master@{#404871}

Powered by Google App Engine
This is Rietveld 408576698