Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2142133002: DevTools: Move Spectrum to components/ (Closed)

Created:
4 years, 5 months ago by flandy
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Move Spectrum from elements/ to components/ so that it can be used in both Sources and Elements. Committed: https://crrev.com/be1bd6dcce6641e0b58a13bce743c39a1706a26d Cr-Commit-Position: refs/heads/master@{#405216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1449 lines) Patch
M third_party/WebKit/Source/devtools/devtools.gypi View 4 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/components/Spectrum.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/module.json View 2 chunks +3 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/components/spectrum.css View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js View 1 chunk +0 lines, -1044 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/module.json View 2 chunks +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/elements/spectrum.css View 1 chunk +0 lines, -400 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
flandy
Please take a look.
4 years, 5 months ago (2016-07-12 17:40:51 UTC) #3
lushnikov
lgtm
4 years, 5 months ago (2016-07-12 17:49:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142133002/1
4 years, 5 months ago (2016-07-12 17:54:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/254274)
4 years, 5 months ago (2016-07-12 20:26:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142133002/1
4 years, 5 months ago (2016-07-13 16:16:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 17:49:26 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 17:49:28 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:51:41 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/be1bd6dcce6641e0b58a13bce743c39a1706a26d
Cr-Commit-Position: refs/heads/master@{#405216}

Powered by Google App Engine
This is Rietveld 408576698