Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: components/autofill/core/browser/personal_data_manager_unittest.cc

Issue 2142123002: [Autofill] Run autofill-profile de-dupe after sync starts if sync is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Register the autofill last version deduped pref for ProfileSyncServiceAutofillTest Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/personal_data_manager_unittest.cc
diff --git a/components/autofill/core/browser/personal_data_manager_unittest.cc b/components/autofill/core/browser/personal_data_manager_unittest.cc
index 231da52dba5b592782a76ed707e4741057349c3e..2ae646b295bb9fbeffe845e943f52de4aa857ff1 100644
--- a/components/autofill/core/browser/personal_data_manager_unittest.cc
+++ b/components/autofill/core/browser/personal_data_manager_unittest.cc
@@ -176,6 +176,7 @@ class PersonalDataManagerTest : public testing::Test {
signin_manager_.get(),
is_incognito);
personal_data_->AddObserver(&personal_data_observer_);
+ personal_data_->OnSyncServiceConfigured(nullptr);
// Verify that the web database has been updated and the notification sent.
EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
@@ -201,6 +202,7 @@ class PersonalDataManagerTest : public testing::Test {
feature_list->InitializeFromCommandLine(kAutofillProfileCleanup.name,
std::string());
base::FeatureList::SetInstance(std::move(feature_list));
+ personal_data_->is_autofill_profile_dedupe_pending_ = true;
}
void SetupReferenceProfile() {
@@ -4601,7 +4603,7 @@ TEST_F(PersonalDataManagerTest, ApplyDedupingRoutine_MergedProfileValues) {
base::HistogramTester histogram_tester;
- personal_data_->ApplyDedupingRoutine();
+ EXPECT_TRUE(personal_data_->ApplyDedupingRoutine());
EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
.WillOnce(QuitMainMessageLoop());
base::RunLoop().Run();
@@ -4694,7 +4696,7 @@ TEST_F(PersonalDataManagerTest, ApplyDedupingRoutine_VerifiedProfileFirst) {
base::HistogramTester histogram_tester;
- personal_data_->ApplyDedupingRoutine();
+ EXPECT_TRUE(personal_data_->ApplyDedupingRoutine());
EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
.WillOnce(QuitMainMessageLoop());
base::RunLoop().Run();
@@ -4766,7 +4768,7 @@ TEST_F(PersonalDataManagerTest, ApplyDedupingRoutine_VerifiedProfileLast) {
base::HistogramTester histogram_tester;
- personal_data_->ApplyDedupingRoutine();
+ EXPECT_TRUE(personal_data_->ApplyDedupingRoutine());
EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
.WillOnce(QuitMainMessageLoop());
base::RunLoop().Run();
@@ -4837,7 +4839,7 @@ TEST_F(PersonalDataManagerTest, ApplyDedupingRoutine_MultipleVerifiedProfiles) {
base::HistogramTester histogram_tester;
- personal_data_->ApplyDedupingRoutine();
+ EXPECT_TRUE(personal_data_->ApplyDedupingRoutine());
EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
.WillOnce(QuitMainMessageLoop());
base::RunLoop().Run();
@@ -5067,7 +5069,7 @@ TEST_F(PersonalDataManagerTest, ApplyDedupingRoutine_MultipleDedupes) {
// |Homer1| should get merged into |Homer2| which should then be merged into
// |Homer3|. |Marge2| should be discarded in favor of |Marge1| which is
// verified. |Homer4| and |Barney| should not be deduped at all.
- personal_data_->ApplyDedupingRoutine();
+ EXPECT_TRUE(personal_data_->ApplyDedupingRoutine());
EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
.WillOnce(QuitMainMessageLoop());
base::RunLoop().Run();

Powered by Google App Engine
This is Rietveld 408576698