components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc - Issue 2142123002: [Autofill] Run autofill-profile de-dupe after sync starts if sync is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

Issue 2142123002: [Autofill] Run autofill-profile de-dupe after sync starts if sync is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Better logging and fix mathp's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc ('k') | components/autofill/core/browser/webdata/autofill_webdata_backend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

diff --git a/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc b/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

index 82fc3e4d6b311368c3fcc6264d3ddbf0fd451782..08cb1d36fb3b17e9cd500565d3968c262ec8037c 100644

--- a/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

+++ b/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

@@ -216,7 +216,10 @@ syncer::SyncMergeResult AutofillWalletSyncableService::MergeDataAndStartSyncing(

std::unique_ptr<syncer::SyncErrorFactory> sync_error_factory) {

DCHECK(thread_checker_.CalledOnValidThread());

sync_processor_ = std::move(sync_processor);

- return SetSyncData(initial_sync_data);

+ syncer::SyncMergeResult result = SetSyncData(initial_sync_data);

+ if (webdata_backend_)

+ webdata_backend_->NotifyThatSyncHasStarted(type);

+ return result;

}

void AutofillWalletSyncableService::StopSyncing(syncer::ModelType type) {